From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 22 Feb 2022 08:36:50 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nMPj8-006e5g-RU for lore@lore.pengutronix.de; Tue, 22 Feb 2022 08:36:50 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nMPj8-0001Am-A4; Tue, 22 Feb 2022 08:36:50 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMPiI-0001A4-SU; Tue, 22 Feb 2022 08:35:58 +0100 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nMPiI-000ZrN-BA; Tue, 22 Feb 2022 08:35:57 +0100 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nMPiG-00FENX-U1; Tue, 22 Feb 2022 08:35:56 +0100 Date: Tue, 22 Feb 2022 08:35:56 +0100 From: Michael Olbrich To: Christian Melki Message-ID: Mail-Followup-To: Christian Melki , p.zabel@pengutronix.de, "ptxdist@pengutronix.de" References: <20220218160838.759601-1-p.zabel@pengutronix.de> <427ed28f-68e0-0a36-c4a9-90e060591d06@t2data.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <427ed28f-68e0-0a36-c4a9-90e060591d06@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH 1/4] libjpeg: enable building libturbojpeg X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: "ptxdist@pengutronix.de" , p.zabel@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Fri, Feb 18, 2022 at 05:27:50PM +0100, Christian Melki wrote: > On 2/18/22 17:08, Philipp Zabel wrote: > > Enable building libturbojpeg for users of the simplified API. > > > > Signed-off-by: Philipp Zabel > > --- > > rules/libjpeg.in | 7 +++++++ > > rules/libjpeg.make | 5 ++++- > > 2 files changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/rules/libjpeg.in b/rules/libjpeg.in > > index 53a9d9e09701..3304c6ac896f 100644 > > --- a/rules/libjpeg.in > > +++ b/rules/libjpeg.in > > @@ -19,4 +19,11 @@ config LIBJPEG_BIN > > cjpeg and djpeg are simple bineries to convert some basic image > > formats to jpeg (cjpeg) or convert them back from jpeg (djpeg) > > > > +config LIBJPEG_TURBO > > + bool > > + prompt "Build and install libturbojpeg" > > + help > > + In addition to the traditional libjpeg API, also provide the less > > + powerful but more straightforward TurboJPEG API. > > + > > endif > > diff --git a/rules/libjpeg.make b/rules/libjpeg.make > > index 559a6d08d504..704f810a4bd4 100644 > > --- a/rules/libjpeg.make > > +++ b/rules/libjpeg.make > > @@ -60,7 +60,7 @@ LIBJPEG_CONF_OPT := \ > > -DWITH_JPEG8=ON \ > > -DWITH_MEM_SRCDST=ON \ > > -DWITH_SIMD=$(call ptx/onoff,LIBJPEG_SIMD) \ > > - -DWITH_TURBOJPEG=OFF > > + -DWITHOUT_TURBOJPEG=$(call ptx/ifdef, PTXCONF_LIBJPEG_TURBO,OFF,ON) > > Looks weird. Didn't -DWITH work? Weird indeed. Philipp, what's going on here? Michael > > > > # ---------------------------------------------------------------------------- > > # Target-Install > > @@ -76,6 +76,9 @@ $(STATEDIR)/libjpeg.targetinstall: > > @$(call install_fixup, libjpeg,DESCRIPTION,missing) > > > > @$(call install_lib, libjpeg, 0, 0, 0644, libjpeg) > > +ifdef PTXCONF_LIBJPEG_TURBO > > + @$(call install_lib, libjpeg, 0, 0, 0644, libturbojpeg) > > +endif > > ifdef PTXCONF_LIBJPEG_BIN > > @$(call install_copy, libjpeg, 0, 0, 0755, -, /usr/bin/cjpeg) > > @$(call install_copy, libjpeg, 0, 0, 0755, -, /usr/bin/djpeg) > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de