Re: [ptxdist] [PATCH 3/3] protobuf: version bump 3.7.1 -> 3.19.4

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Feb 04, 2022 at 05:28:09PM +0100, Clemens Gruber wrote:
> Running autogen.sh is no longer necessary.
> 
> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> ---
>  patches/protobuf-all-3.7.1/autogen.sh | 1 -
>  rules/protobuf.make                   | 4 ++--
>  2 files changed, 2 insertions(+), 3 deletions(-)
>  delete mode 120000 patches/protobuf-all-3.7.1/autogen.sh
> 
> diff --git a/patches/protobuf-all-3.7.1/autogen.sh b/patches/protobuf-all-3.7.1/autogen.sh
> deleted file mode 120000
> index 9f8a4cb7d..000000000
> --- a/patches/protobuf-all-3.7.1/autogen.sh
> +++ /dev/null
> @@ -1 +0,0 @@
> -../autogen.sh
> \ No newline at end of file
> diff --git a/rules/protobuf.make b/rules/protobuf.make
> index a5c126443..1cb4bd7d0 100644
> --- a/rules/protobuf.make
> +++ b/rules/protobuf.make
> @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_PROTOBUF) += protobuf
>  #
>  # Paths and names
>  #
> -PROTOBUF_VERSION	:= 3.7.1
> -PROTOBUF_MD5		:= cda6ae370a5df941f8aa837c8a0292ba
> +PROTOBUF_VERSION	:= 3.19.4
> +PROTOBUF_MD5		:= e96c719ff844bc2fe635efab79e71f55

This breaks building grpc:

In file included from .../build-host/grpc-1.21.0-build/gens/src/proto/grpc/status/status.grpc.pb.h:30,
                 from .../build-host/grpc-1.21.0-build/gens/src/proto/grpc/status/status.grpc.pb.cc:6:
.../build-host/grpc-1.21.0/include/grpcpp/impl/codegen/proto_utils.h: In function 'grpc::Status grpc::GenericDeserialize(grpc::ByteBuffer*, grpc::protobuf::Message*)':
.../build-host/grpc-1.21.0/include/grpcpp/impl/codegen/proto_utils.h:86:48: error: no matching function for call to 'google::protobuf::io::CodedInputStream::SetTotalBytesLimit(int, int)'
In file included from .../build-host/grpc-1.21.0-build/gens/src/proto/grpc/status/status.pb.h:23,
                 from .../build-host/grpc-1.21.0-build/gens/src/proto/grpc/status/status.grpc.pb.cc:5:
.../sysroot-host/include/google/protobuf/io/coded_stream.h:406:8: note: candidate: 'void google::protobuf::io::CodedInputStream::SetTotalBytesLimit(int)'
.../sysroot-host/include/google/protobuf/io/coded_stream.h:406:8: note: candidate expects 1 argument, 2 provided
make[2]: *** [CMakeFiles/grpc++_error_details.dir/build.make:108:
CMakeFiles/grpc++_error_details.dir/gens/src/proto/grpc/status/status.grpc.pb.cc.o]
Error 1

You have done most of the work on that package. Can you take a look at
that. I guess it should be updated as well.

Michael

>  PROTOBUF		:= protobuf-all-$(PROTOBUF_VERSION)
>  PROTOBUF_SUFFIX		:= tar.gz
>  PROTOBUF_URL		:= https://github.com/google/protobuf/releases/download/v$(PROTOBUF_VERSION)/$(PROTOBUF).$(PROTOBUF_SUFFIX)
> -- 
> 2.35.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de