Re: [ptxdist] [PATCH 1/3] hiredis: new package

[Alexander Dahl <ada@thorsis.com>]

Hei hei,

this tends to go offtopic, so I dropped most of the context … O:-)

Am Mon, Feb 07, 2022 at 02:33:29PM +0100 schrieb Clemens Gruber:
> > Maybe libhiredis makes something different than usual. Haven't looked
> > into it. O:-)
> 
> It seems the libhiredis cmake config only sets VERSION but not
> SOVERSION, so SOVERSION is assumed to be 1.0.0 as well, which explains
> why there is only one symlink, but not why that one is not present in
> the rootfs.

Made the mistake to look at this:

https://github.com/redis/hiredis/blob/master/CMakeLists.txt

Oh boy, don't even know where to start, this is miles away from how to
do modern CMake.  But it shows what you already noticed, SOVERSION is
not used at all.  Maybe someone should point them at this:

https://cmake.org/cmake/help/v3.4/prop_tgt/SOVERSION.html

A good start for modernizing (and reducing build time) would be this
PR: 

https://github.com/redis/hiredis/pull/951

But I won't dive in deeper, already put too much time in this. O:-)

Greets
Alex


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de