From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 07 Feb 2022 13:54:45 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>) id 1nH3XY-008GSE-Ve for lore@lore.pengutronix.de; Mon, 07 Feb 2022 13:54:45 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from <ptxdist-bounces@pengutronix.de>) id 1nH3XY-0001uY-8T; Mon, 07 Feb 2022 13:54:44 +0100 Received: from mail.pqgruber.com ([2a05:d014:575:f70b:4f2c:8f1d:40c4:b13e]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from <clemens.gruber@pqgruber.com>) id 1nH3Wx-0001uN-6h for ptxdist@pengutronix.de; Mon, 07 Feb 2022 13:54:07 +0100 Received: from workstation (213-47-165-233.cable.dynamic.surfer.at [213.47.165.233]) by mail.pqgruber.com (Postfix) with ESMTPSA id 34F47C2FB90 for <ptxdist@pengutronix.de>; Mon, 7 Feb 2022 13:54:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pqgruber.com; s=mail; t=1644238446; bh=npKYih/zTIzfV6lH8jZ/4klsAZstHA+9XHuqbOJI9sc=; h=Date:From:To:Subject:References:In-Reply-To:From; b=SLoS7Ck+8VAihCztmcNasiHuuo6Gf80pP6ay7m5mG13bcxjROdtSSNRN2JS+PUc91 7EfZpLT9qBfjAcSVGFHvWBJ9EbNxwC5NvKALKnex0p+TgDOWdu5Zg4u86pzy8YQrif NSiqQ1Wr/X2kxYSe+X4CdTup3wkMsBzMHG6lJ8r8= Date: Mon, 7 Feb 2022 13:54:04 +0100 From: Clemens Gruber <clemens.gruber@pqgruber.com> To: ptxdist@pengutronix.de Message-ID: <YgEWbOR0FHvlg3zI@workstation> References: <20220204162809.830058-1-clemens.gruber@pqgruber.com> <20220207073936.GQ11273@pengutronix.de> <YgDgWcZD6dQDMb+F@workstation> <20220207103909.GB538@falbala.internal.home.lespocky.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220207103909.GB538@falbala.internal.home.lespocky.de> X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-102.9 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 1/3] hiredis: new package X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de> List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe> List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/> List-Post: <mailto:ptxdist@pengutronix.de> List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help> List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, <mailto:ptxdist-request@pengutronix.de?subject=subscribe> Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" <ptxdist-bounces@pengutronix.de> X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hi, On Mon, Feb 07, 2022 at 11:39:10AM +0100, Alexander Dahl wrote: > Hei hei, > > On Mon, Feb 07, 2022 at 10:03:21AM +0100, Clemens Gruber wrote: > > On Mon, Feb 07, 2022 at 08:39:36AM +0100, Michael Olbrich wrote: > > > On Fri, Feb 04, 2022 at 05:28:07PM +0100, Clemens Gruber wrote: > > > > Adds a new package for hiredis, a minimalistic C client library for > > > > Redis. > > > > > > > > Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com> > > > > --- > > > > rules/hiredis.in | 8 ++++++ > > > > rules/hiredis.make | 61 ++++++++++++++++++++++++++++++++++++++++++++++ > > > > 2 files changed, 69 insertions(+) > > > > create mode 100644 rules/hiredis.in > > > > create mode 100644 rules/hiredis.make > > > > > > > > diff --git a/rules/hiredis.in b/rules/hiredis.in > > > > new file mode 100644 > > > > index 000000000..d416d69c4 > > > > --- /dev/null > > > > +++ b/rules/hiredis.in > > > > @@ -0,0 +1,8 @@ > > > > +## SECTION=system_libraries > > > > + > > > > +config HIREDIS > > > > + tristate > > > > + select HOST_CMAKE > > > > + prompt "hiredis " > > > > + help > > > > + Hiredis is a minimalistic C client library for the Redis database. > > > > diff --git a/rules/hiredis.make b/rules/hiredis.make > > > > new file mode 100644 > > > > index 000000000..10e6d81d2 > > > > --- /dev/null > > > > +++ b/rules/hiredis.make > > > > @@ -0,0 +1,61 @@ > > > > +# -*-makefile-*- > > > > +# > > > > +# Copyright (C) 2022 by Clemens Gruber <clemens.gruber@pqgruber.com> > > > > +# > > > > +# For further information about the PTXdist project and license conditions > > > > +# see the README file. > > > > +# > > > > + > > > > +# > > > > +# We provide this package > > > > +# > > > > +PACKAGES-$(PTXCONF_HIREDIS) += hiredis > > > > + > > > > +# > > > > +# Paths and names > > > > +# > > > > +HIREDIS_VERSION := 1.0.2 > > > > +HIREDIS_MD5 := 58e8313188f66ed1be1c220d14a7752e > > > > +HIREDIS := hiredis-$(HIREDIS_VERSION) > > > > +HIREDIS_SUFFIX := tar.gz > > > > +HIREDIS_URL := https://github.com/redis/hiredis/archive/v$(HIREDIS_VERSION).$(HIREDIS_SUFFIX) > > > > +HIREDIS_SOURCE := $(SRCDIR)/$(HIREDIS).$(HIREDIS_SUFFIX) > > > > +HIREDIS_DIR := $(BUILDDIR)/$(HIREDIS) > > > > +HIREDIS_LICENSE := BSD-3-Clause > > > > > > Please add _LICENSE_FILES as well. > > > > > > > + > > > > +# ---------------------------------------------------------------------------- > > > > +# Prepare > > > > +# ---------------------------------------------------------------------------- > > > > + > > > > +# > > > > +# cmake > > > > +# > > > > +HIREDIS_CONF_TOOL := cmake > > > > + > > > > +HIREDIS_CONF_OPT := \ > > > > + $(CROSS_CMAKE_USR) \ > > > > + -DDISABLE_TESTS=ON \ > > > > + -DENABLE_SSL=OFF > > > > + > > > > + > > > > +# ---------------------------------------------------------------------------- > > > > +# Target-Install > > > > +# ---------------------------------------------------------------------------- > > > > + > > > > +$(STATEDIR)/hiredis.targetinstall: > > > > + @$(call targetinfo) > > > > + > > > > + @$(call install_init, hiredis) > > > > + @$(call install_fixup, hiredis,PRIORITY,optional) > > > > + @$(call install_fixup, hiredis,SECTION,base) > > > > + @$(call install_fixup, hiredis,AUTHOR,"Clemens Gruber <clemens.gruber@pqgruber.com>") > > > > + @$(call install_fixup, hiredis,DESCRIPTION,"Minimalistic C client for Redis") > > > > + > > > > + @$(call install_lib, hiredis, 0, 0, 0644, libhiredis) > > > > + @$(call install_link, hiredis, libhiredis.so.1.0.0, /usr/lib/libhiredis.so) > > > > > > In general, this link should not be needed. If it really is needed then > > > please add a comment why. > > > > Maybe you can help me out here: If I don't call install_link, the > > libhiredis.so link is not present in my rootfs image, even though it is > > present in platform-xyz/packages/hiredis-1.0.2/usr/lib and in > > platform-xyz/root/usr/lib > > I would expect this. Usually you have three pieces: > > libfoo.so.1.0.0 (real binary file) > libfoo.so.1 (symlink to libfoo.so.1.0.0, used at runtime by users of the lib) > libfoo.so (symlink, used at build time) > > > Still in my rootfs image, there is only /usr/lib/libhiredis.so.1.0.0 > > It is a normal root.ext2 image with ext2fs type ext4. > > > > Any idea why that is? > > No idea why that is, but without further knowledge of that lib I would > expect to see libhiredis.so.1 on the target instead of libhiredis.so > (which is probably only needed in sysroot-target). I forgot to mention that the libhiredis.so.1 link is also created in platform-xyz/packages/.. and platform-xyz/root/.. I should probably have added the create_link for that one as well but did not need it because a binary blob not under my control dynloads /usr/lib/libhiredis.so Maybe Michael can shed some light on why the links are not present in the rootfs. Just for testing I enabled the creation of a root.tgz file (image-root-tgz). There, the links are also missing. Thanks, Clemens _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de