From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 28 Jan 2022 13:33:17 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nDQRJ-00Fyy4-Ni for lore@lore.pengutronix.de; Fri, 28 Jan 2022 13:33:17 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nDQRJ-00045T-0R; Fri, 28 Jan 2022 13:33:17 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDQRB-000453-6W; Fri, 28 Jan 2022 13:33:09 +0100 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nDQRB-00CyjL-3a; Fri, 28 Jan 2022 13:33:08 +0100 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nDQR9-00GwkI-DS; Fri, 28 Jan 2022 13:33:07 +0100 Date: Fri, 28 Jan 2022 13:33:07 +0100 From: Michael Olbrich To: Michael Riesch Message-ID: Mail-Followup-To: Michael Riesch , ptxdist@pengutronix.de, m.tretter@pengutronix.de References: <20220124120942.557161-1-michael.riesch@wolfvision.net> <20220124120942.557161-6-michael.riesch@wolfvision.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220124120942.557161-6-michael.riesch@wolfvision.net> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [RFC PATCH v5 5/5] barebox.rockchip: add binary firmware blobs for quartz64 and rk3568-evb1 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de, m.tretter@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Mon, Jan 24, 2022 at 01:09:42PM +0100, Michael Riesch wrote: > Currently, the mainline OP-TEE and TF-A sources do not support the > RK356x SoCs. Therefore, the only option is to use the binary blobs > provided by Rockchip. This patch integrates these blobs (along the SDRAM > initialization binary) for the Pine64 Quartz64 board and the RK3568 > EVB1 into barebox. > > Signed-off-by: Michael Riesch > --- > platforms/barebox.rockchip.in | 13 +++++++++++++ > rules/barebox.rockchip.make | 18 ++++++++++++++++++ > 2 files changed, 31 insertions(+) > create mode 100644 rules/barebox.rockchip.make > > diff --git a/platforms/barebox.rockchip.in b/platforms/barebox.rockchip.in > index 8ecdb0762..9aad4eaf8 100644 > --- a/platforms/barebox.rockchip.in > +++ b/platforms/barebox.rockchip.in > @@ -1 +1,14 @@ > ## SECTION=barebox_firmware > + > +config BAREBOX_NEEDS_FIRMWARE_ROCKCHIP > + prompt "barebox needs firmware-rockchip" > + bool > + depends on ARCH_ARM64 > + select FIRMWARE_ROCKCHIP if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP This does not work. It must look like this or the build dependency is not created: config BAREBOX_NEEDS_FIRMWARE_ROCKCHIP prompt "barebox needs firmware-rockchip" bool depends on ARCH_ARM64 config BAREBOX select FIRMWARE_ROCKCHIP if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP Multiple occurrences of the same symbol are merged, so this works just fine as long as 'BAREBOX' is fully defined somewhere else. Michael > + select FIRMWARE_ROCKCHIP_RK356x_BL31 if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP > + select FIRMWARE_ROCKCHIP_RK356x_BL32 if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP > + select FIRMWARE_ROCKCHIP_RK3566_SDRAM if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP > + select FIRMWARE_ROCKCHIP_RK3568_SDRAM if BAREBOX_NEEDS_FIRMWARE_ROCKCHIP > + help > + Select this if barebox needs the non-free Rockchip firmware > + blobs. > diff --git a/rules/barebox.rockchip.make b/rules/barebox.rockchip.make > new file mode 100644 > index 000000000..0255b2b4d > --- /dev/null > +++ b/rules/barebox.rockchip.make > @@ -0,0 +1,18 @@ > +# -*-makefile-*- > +# > +# Copyright (C) 2021 by Michael Riesch > +# > +# For further information about the PTXdist project and license conditions > +# see the README file. > +# > + > +ifdef PTXCONF_BAREBOX_NEEDS_FIRMWARE_ROCKCHIP > + > +BAREBOX_INJECT_FILES += rk3568_bl31_v1.24.elf:firmware/rk3568-bl31.bin > +BAREBOX_INJECT_FILES += rk3568_bl32_v1.05.bin:firmware/rk3568-op-tee.bin > + > +BAREBOX_INJECT_FILES += rk3566_ddr_1056MHz_v1.08.bin:arch/arm/boards/pine64-quartz64/sdram-init.bin > + > +BAREBOX_INJECT_FILES += rk3568_ddr_1560MHz_v1.08.bin:arch/arm/boards/rockchip-rk3568-evb/sdram-init.bin > + > +endif > -- > 2.30.2 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de