From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 28 Jan 2022 10:16:44 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nDNN6-00Foko-Dn for lore@lore.pengutronix.de; Fri, 28 Jan 2022 10:16:44 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nDNN5-0000oS-Ku; Fri, 28 Jan 2022 10:16:43 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDNMZ-0000o3-9U; Fri, 28 Jan 2022 10:16:11 +0100 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nDNMZ-00CwWh-1W; Fri, 28 Jan 2022 10:16:10 +0100 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nDNMX-00GDFA-EU; Fri, 28 Jan 2022 10:16:09 +0100 Date: Fri, 28 Jan 2022 10:16:09 +0100 From: Michael Olbrich To: Christian Melki Message-ID: Mail-Followup-To: Christian Melki , ptxdist@pengutronix.de References: <20220125150124.6297-1-christian.melki@t2data.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220125150124.6297-1-christian.melki@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [Might-be-helpful-to-someone-PATCH] scripts/kconfig: (Re-)add warning about unassigned symbols. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Tue, Jan 25, 2022 at 04:01:24PM +0100, Christian Melki wrote: > Kconfig/lxdialog is inherited from the linux kernel. > That version removed a warning regarding unassigned symbols. > Commit f072181e6403b0fe2e2aa800a005497b748fd284, > kconfig: drop the ""trying to assign nonexistent symbol" warning. > > This warning actually helps detecting symbol renames which are lost in > translation which is helpful when doing oldconfigs etc. Good argument. I like it. When I update kconfig, then I overwrite it with the new version. Then I apply the patches from scripts/ptx-modifications/. So any local changes must be added there too. Can you do that? Just add exactly this patch there and add it to the series file. Then amend the commit or create a second one. Either way works for me. Michael > Signed-off-by: Christian Melki > --- > scripts/kconfig/confdata.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c > index c5f4b552b..09777fdfe 100644 > --- a/scripts/kconfig/confdata.c > +++ b/scripts/kconfig/confdata.c > @@ -426,6 +426,7 @@ load: > if (def == S_DEF_USER) { > sym = sym_find(line + 2 + strlen(CONFIG_)); > if (!sym) { > + conf_warning("trying to assign nonexistent symbol %s", line + 2 + strlen(CONFIG_)); > sym_add_change_count(1); > continue; > } > @@ -468,8 +469,10 @@ load: > * include/config/foo.h must be touched. > */ > conf_touch_dep(line + strlen(CONFIG_)); > - else > + else { > + conf_warning("trying to assign nonexistent symbol %s", line + strlen(CONFIG_)); > sym_add_change_count(1); > + } > continue; > } > > -- > 2.30.2 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de