Re: [ptxdist] [PATCH] image-hdimg.make: Add PROJECT and PROJECT_VERSION variables.

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Jan 14, 2022 at 12:56:47PM +0100, Christian Melki wrote:
> Ideally, I'd like this to be in the generic genimage env.
> I need this to be able to name images according to the project.

I don't really like adding random stuff here. And it's easy to expand this
locally:

IMAGE_HDIMG_ENV += \
	PROJECT=$(PTXCONF_PROJECT) \
	PROJECT_VERSION=$(PTXCONF_PROJECT_VERSION)

In rules/image-hdimg.<something>.make in your BSP since ptxdist-2021.12.0 or in
rules/post/<something>.make before that.
So you don't need to overwrite the upstream rule entirely and it's easy to
maintain.

Michael

> Signed-off-by: Christian Melki <christian.melki@t2data.com>
> ---
>  rules/image-hdimg.make | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/rules/image-hdimg.make b/rules/image-hdimg.make
> index b470c0fb6..6f0012a85 100644
> --- a/rules/image-hdimg.make
> +++ b/rules/image-hdimg.make
> @@ -57,6 +57,8 @@ IMAGE_HDIMG_ENV = \
>  	PARTITION_TABLE_TYPE=$(call ptx/ifdef, PTXCONF_IMAGE_HDIMG_GPT,gpt,mbr) \
>  	PARTITION_TYPE_SUFFIX=$(call ptx/ifdef, PTXCONF_IMAGE_HDIMG_GPT,-uuid) \
>  	ROOT_PARTITION_TYPE=$(call ptx/ifdef, PTXCONF_IMAGE_HDIMG_GPT,L,0x83) \
> +	PROJECT=$(PTXCONF_PROJECT) \
> +	PROJECT_VERSION=$(PTXCONF_PROJECT_VERSION) \
>  	$(IMAGE_HDIMG_BOOTLOADER_ENV)
>  
>  $(IMAGE_HDIMG_IMAGE):
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de