Re: [ptxdist] [PATCH v4 2/4] add package for rockchip firmware binaries

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Jan 10, 2022 at 07:05:56AM +0100, Michael Riesch wrote:
> Hello Michael,
> 
> On 1/7/22 2:56 PM, Michael Olbrich wrote:
> > On Mon, Dec 20, 2021 at 01:08:55PM +0100, Michael Riesch wrote:
> >> Rockchip provides the SDRAM initialization as well as BL31/BL32
> >> firmware for their SoCs in binary form. Add a package that downloads
> >> those binaries for further use in e.g., barebox.
> >>
> >> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> >> [revised and extended Kconfig]
> >> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> >> ---
> >>  platforms/firmware-rockchip.in | 41 +++++++++++++++++++
> >>  rules/firmware-rockchip.make   | 74 ++++++++++++++++++++++++++++++++++
> >>  2 files changed, 115 insertions(+)
> >>  create mode 100644 platforms/firmware-rockchip.in
> >>  create mode 100644 rules/firmware-rockchip.make
> >>
> >> diff --git a/platforms/firmware-rockchip.in b/platforms/firmware-rockchip.in
> >> new file mode 100644
> >> index 000000000..aa702416d
> >> --- /dev/null
> >> +++ b/platforms/firmware-rockchip.in
> >> @@ -0,0 +1,41 @@
> >> +## SECTION=non_free_firmware
> >> +
> >> +menuconfig FIRMWARE_ROCKCHIP
> >> +	bool
> >> +	prompt "Rockchip firmware binaries    "
> >> +	help
> >> +	  Rockchip prebuilt SDRAM initialization and TF-A binaries.
> >> +
> >> +if FIRMWARE_ROCKCHIP
> >> +
> >> +config FIRMWARE_ROCKCHIP_RK3566_SDRAM
> > 
> > Right, the options must be part of the barebox integration, otherwise they
> > may be disabled here and then missing later.
> 
> Are you sure? In principle u-boot could use those binaries as well (if
> anyone is keen on using it), couldn't it?
> 
> But the dependencies are missing here I guess.

You're just copying some file to sysroot here. It does not matter if there
are some extra unused files. That happens all the time. No need for an
option here, because the option is needed at the other end anyways.

Michael

> > I'll comment some more on the other patch.
> > 
> > Michael
> > 
> >> +	bool
> >> +	prompt "RK3566 SDRAM init"
> >> +	help
> >> +	  Rockchip RK3566 SDRAM initialization binary.
> >> +	  Compatible with e.g., the Pine64 Quartz64 Model A board.
> >> +
> >> +config FIRMWARE_ROCKCHIP_RK3568_SDRAM
> >> +	bool
> >> +	prompt "RK3568 SDRAM init"
> >> +	help
> >> +	  Rockchip RK3568 SDRAM initialization binary.
> >> +	  Compatible with e.g., the Rockchip RK3568 EVB1 board.
> >> +
> >> +config FIRMWARE_ROCKCHIP_RK356x_BL31
> >> +	bool
> >> +	prompt "RK356x BL31 binary"
> >> +	help
> >> +	  Rockchip RK3566/RK3568 BL31 binary.
> >> +	  Compatible with e.g., the Pine64 Quartz64 Model A board
> >> +	  and the Rockchip RK3568 EVB1 board.
> >> +
> >> +config FIRMWARE_ROCKCHIP_RK356x_BL32
> >> +	bool
> >> +	prompt "RK356x BL32 binary"
> >> +	help
> >> +	  Rockchip RK3566/RK3568 BL32 binary.
> >> +	  Compatible with e.g., the Pine64 Quartz64 Model A board
> >> +	  and the Rockchip RK3568 EVB1 board.
> >> +
> >> +endif
> >> diff --git a/rules/firmware-rockchip.make b/rules/firmware-rockchip.make
> >> new file mode 100644
> >> index 000000000..dd50c865a
> >> --- /dev/null
> >> +++ b/rules/firmware-rockchip.make
> >> @@ -0,0 +1,74 @@
> >> +# -*-makefile-*-
> >> +#
> >> +# Copyright (C) 2021 by Michael Tretter <m.tretter@pengutronix.de>
> >> +#
> >> +# For further information about the PTXdist project and license conditions
> >> +# see the README file.
> >> +#
> >> +
> >> +#
> >> +# We provide this package
> >> +#
> >> +PACKAGES-$(PTXCONF_FIRMWARE_ROCKCHIP) += firmware-rockchip
> >> +
> >> +FIRMWARE_ROCKCHIP_VERSION	:= 2021-06-01-g7d631e0d
> >> +FIRMWARE_ROCKCHIP_MD5		:= 4ca62f76ca75019dc708c4cb7cc31b0a
> >> +FIRMWARE_ROCKCHIP		:= firmware-rockchip-$(FIRMWARE_ROCKCHIP_VERSION)
> >> +FIRMWARE_ROCKCHIP_SUFFIX	:= zip
> >> +FIRMWARE_ROCKCHIP_URL		:= https://github.com/rockchip-linux/rkbin/archive/$(FIRMWARE_ROCKCHIP_VERSION).$(FIRMWARE_ROCKCHIP_SUFFIX)
> >> +FIRMWARE_ROCKCHIP_SOURCE	:= $(SRCDIR)/$(FIRMWARE_ROCKCHIP).$(FIRMWARE_ROCKCHIP_SUFFIX)
> >> +FIRMWARE_ROCKCHIP_DIR		:= $(BUILDDIR)/$(FIRMWARE_ROCKCHIP)
> >> +FIRMWARE_ROCKCHIP_LICENSE	:= proprietary
> >> +
> >> +# ----------------------------------------------------------------------------
> >> +# Prepare
> >> +# ----------------------------------------------------------------------------
> >> +
> >> +FIRMWARE_ROCKCHIP_CONF_TOOL := NO
> >> +
> >> +# ----------------------------------------------------------------------------
> >> +# Compile
> >> +# ----------------------------------------------------------------------------
> >> +
> >> +$(STATEDIR)/firmware-rockchip.compile:
> >> +	@$(call targetinfo)
> >> +	@$(call touch)
> >> +
> >> +# ----------------------------------------------------------------------------
> >> +# Install
> >> +# ----------------------------------------------------------------------------
> >> +
> >> +$(STATEDIR)/firmware-rockchip.install:
> >> +	@$(call targetinfo)
> >> +
> >> +ifdef PTXCONF_FIRMWARE_ROCKCHIP_RK3566_SDRAM
> >> +	install -v -D -m644 $(FIRMWARE_ROCKCHIP_DIR)/bin/rk35/rk3566_ddr_1056MHz_v1.08.bin \
> >> +		$(FIRMWARE_ROCKCHIP_PKGDIR)/usr/lib/firmware/rk3566_ddr_1056MHz_v1.08.bin
> >> +endif
> >> +
> >> +ifdef PTXCONF_FIRMWARE_ROCKCHIP_RK3568_SDRAM
> >> +	install -v -D -m644 $(FIRMWARE_ROCKCHIP_DIR)/bin/rk35/rk3568_ddr_1560MHz_v1.08.bin \
> >> +		$(FIRMWARE_ROCKCHIP_PKGDIR)/usr/lib/firmware/rk3568_ddr_1560MHz_v1.08.bin
> >> +endif
> >> +
> >> +ifdef PTXCONF_FIRMWARE_ROCKCHIP_RK356x_BL31
> >> +	install -v -D -m644 $(FIRMWARE_ROCKCHIP_DIR)/bin/rk35/rk3568_bl31_v1.24.elf \
> >> +		$(FIRMWARE_ROCKCHIP_PKGDIR)/usr/lib/firmware/rk3568_bl31_v1.24.elf
> >> +endif
> >> +
> >> +ifdef PTXCONF_FIRMWARE_ROCKCHIP_RK356x_BL32
> >> +	install -v -D -m644 $(FIRMWARE_ROCKCHIP_DIR)/bin/rk35/rk3568_bl32_v1.05.bin \
> >> +		$(FIRMWARE_ROCKCHIP_PKGDIR)/usr/lib/firmware/rk3568_bl32_v1.05.bin
> >> +endif
> >> +
> >> +	@$(call touch)
> >> +
> >> +# ----------------------------------------------------------------------------
> >> +# Target-Install
> >> +# ----------------------------------------------------------------------------
> >> +
> >> +$(STATEDIR)/firmware-rockchip.targetinstall:
> >> +	@$(call targetinfo)
> >> +	@$(call touch)
> >> +
> >> +# vim: syntax=make
> >> -- 
> >> 2.30.2
> >>
> >>
> >> _______________________________________________
> >> ptxdist mailing list
> >> ptxdist@pengutronix.de
> >> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> >>
> > 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de