From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 05 Jan 2022 13:47:08 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n55h6-00BlKa-9Q for lore@lore.pengutronix.de; Wed, 05 Jan 2022 13:47:08 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1n55h5-0001Dt-Bh; Wed, 05 Jan 2022 13:47:07 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n55gv-0001Di-3x; Wed, 05 Jan 2022 13:46:57 +0100 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1n55gu-008bKC-Vp; Wed, 05 Jan 2022 13:46:56 +0100 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1n55gt-0000wS-Io; Wed, 05 Jan 2022 13:46:55 +0100 Date: Wed, 5 Jan 2022 13:46:55 +0100 From: Michael Olbrich To: Christian Melki Message-ID: Mail-Followup-To: Christian Melki , ptxdist@pengutronix.de References: <20211222130304.2549154-1-christian.melki@t2data.com> <20211222130304.2549154-11-christian.melki@t2data.com> <2b094c16-d14c-cefc-9369-c137366275b4@t2data.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2b094c16-d14c-cefc-9369-c137366275b4@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] libcap: Version bump 2.51 -> 2.62. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Wed, Jan 05, 2022 at 01:32:11PM +0100, Christian Melki wrote: > https://git.kernel.org/pub/scm/libs/libcap/libcap.git/tree/Make.Rules?h=v1.2.62&id=cc91f55960ce81e7cc24ef0bf729bdf02e2f60e1#n100 > > Maybe I misunderstood the rationale behind it. > Anyway, that comment led to the change for the new version. Right, so the change is correct for host-libcap. But it should be part of the version bump. For me, the patch came before the version bump patch, so I looked at the old code... So, squash the two patches but remove the USE_GPERF=no from the target package. Michael > Regards, > Christian > > On 1/5/22 1:21 PM, Michael Olbrich wrote: > > On Wed, Dec 22, 2021 at 02:02:52PM +0100, Christian Melki wrote: > > > Update posix capability library. > > > > > > Signed-off-by: Christian Melki > > > --- > > > rules/libcap.make | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/rules/libcap.make b/rules/libcap.make > > > index 5ed11b1f3..3159f7b01 100644 > > > --- a/rules/libcap.make > > > +++ b/rules/libcap.make > > > @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_LIBCAP) += libcap > > > # > > > # Paths and names > > > # > > > -LIBCAP_VERSION := 2.51 > > > -LIBCAP_MD5 := 4c9febc1bf0afca6a4d9f86fcdb6d900 > > > +LIBCAP_VERSION := 2.62 > > > +LIBCAP_MD5 := 342c7560ed2103899f6914d1de75a89f > > > LIBCAP := libcap-$(LIBCAP_VERSION) > > > LIBCAP_SUFFIX := tar.xz > > > LIBCAP_URL := \ > > > @@ -35,6 +35,7 @@ LIBCAP_MAKE_OPT := \ > > > BUILD_CC=$(HOSTCC) \ > > > DYNAMIC=yes \ > > > GOLANG=no \ > > > + USE_GPERF=no \ > > > > Ah, maybe the USE_GPERF is from the new version? (See my question about > > host-libcap). > > > > For the target package, we select HOST_GPERF, so it should be used here. > > If I remember this correctly then libcap performs better at runtime if > > gperf is available at build-time. So we want it for the target package, but > > we don't care about the host package. > > > > Michael > > > > > LIBATTR=$(call ptx/yesno, PTXCONF_LIBCAP_SETCAP) \ > > > PAM_CAP=$(call ptx/yesno, PTXCONF_GLOBAL_PAM) > > > -- > > > 2.30.2 > > > > > > > > > _______________________________________________ > > > ptxdist mailing list > > > ptxdist@pengutronix.de > > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > > > > > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de