Re: [ptxdist] [PATCH] libcap: Version bump 2.51 -> 2.62.

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Jan 05, 2022 at 01:32:11PM +0100, Christian Melki wrote:
> https://git.kernel.org/pub/scm/libs/libcap/libcap.git/tree/Make.Rules?h=v1.2.62&id=cc91f55960ce81e7cc24ef0bf729bdf02e2f60e1#n100
> 
> Maybe I misunderstood the rationale behind it.
> Anyway, that comment led to the change for the new version.

Right, so the change is correct for host-libcap. But it should be part of
the version bump. For me, the patch came before the version bump patch, so
I looked at the old code...
So, squash the two patches but remove the USE_GPERF=no from the target
package.

Michael

> Regards,
> Christian
> 
> On 1/5/22 1:21 PM, Michael Olbrich wrote:
> > On Wed, Dec 22, 2021 at 02:02:52PM +0100, Christian Melki wrote:
> > > Update posix capability library.
> > > 
> > > Signed-off-by: Christian Melki <christian.melki@t2data.com>
> > > ---
> > >   rules/libcap.make | 5 +++--
> > >   1 file changed, 3 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/rules/libcap.make b/rules/libcap.make
> > > index 5ed11b1f3..3159f7b01 100644
> > > --- a/rules/libcap.make
> > > +++ b/rules/libcap.make
> > > @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_LIBCAP) += libcap
> > >   #
> > >   # Paths and names
> > >   #
> > > -LIBCAP_VERSION	:= 2.51
> > > -LIBCAP_MD5	:= 4c9febc1bf0afca6a4d9f86fcdb6d900
> > > +LIBCAP_VERSION	:= 2.62
> > > +LIBCAP_MD5	:= 342c7560ed2103899f6914d1de75a89f
> > >   LIBCAP		:= libcap-$(LIBCAP_VERSION)
> > >   LIBCAP_SUFFIX	:= tar.xz
> > >   LIBCAP_URL	:= \
> > > @@ -35,6 +35,7 @@ LIBCAP_MAKE_OPT	:= \
> > >   	BUILD_CC=$(HOSTCC) \
> > >   	DYNAMIC=yes \
> > >   	GOLANG=no \
> > > +	USE_GPERF=no \
> > 
> > Ah, maybe the USE_GPERF is from the new version? (See my question about
> > host-libcap).
> > 
> > For the target package, we select HOST_GPERF, so it should be used here.
> > If I remember this correctly then libcap performs better at runtime if
> > gperf is available at build-time. So we want it for the target package, but
> > we don't care about the host package.
> > 
> > Michael
> > 
> > >   	LIBATTR=$(call ptx/yesno, PTXCONF_LIBCAP_SETCAP) \
> > >   	PAM_CAP=$(call ptx/yesno, PTXCONF_GLOBAL_PAM)
> > > -- 
> > > 2.30.2
> > > 
> > > 
> > > _______________________________________________
> > > ptxdist mailing list
> > > ptxdist@pengutronix.de
> > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> > > 
> > 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de