From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 30 Nov 2021 14:16:46 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ms302-0001Xg-EM for lore@lore.pengutronix.de; Tue, 30 Nov 2021 14:16:46 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ms302-0006Vr-0a; Tue, 30 Nov 2021 14:16:46 +0100 Received: from mail.thorsis.com ([92.198.35.195]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ms2zY-0006V8-K8 for ptxdist@pengutronix.de; Tue, 30 Nov 2021 14:16:18 +0100 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id 37000F33 for ; Tue, 30 Nov 2021 14:16:15 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nGN6sO6Wr4HX for ; Tue, 30 Nov 2021 14:16:11 +0100 (CET) Received: by mail.thorsis.com (Postfix, from userid 109) id 42ED61B38; Tue, 30 Nov 2021 14:16:11 +0100 (CET) Date: Tue, 30 Nov 2021 14:16:02 +0100 From: Alexander Dahl To: Christian Melki Message-ID: Mail-Followup-To: Christian Melki , ptxdist@pengutronix.de References: <20211130103926.618168-1-christian.melki@t2data.com> Content-Disposition: inline In-Reply-To: <20211130103926.618168-1-christian.melki@t2data.com> X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,BAYES_00,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH v3] U-Boot: Add option to disable OOT builds X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hello Christian, Am Tue, Nov 30, 2021 at 11:39:26AM +0100 schrieb Christian Melki: > This option sometimes breaks builds with various external dependencies. > Especially vendor trees that have sourcedir path references. > > Signed-off-by: Christian Melki > --- > platforms/u-boot.in | 10 ++++++++++ > rules/u-boot.make | 12 ++++++++++-- > 2 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/platforms/u-boot.in b/platforms/u-boot.in > index 410391fe8..0d8213f45 100644 > --- a/platforms/u-boot.in > +++ b/platforms/u-boot.in > @@ -20,6 +20,16 @@ config U_BOOT_MD5 > string > prompt "U-Boot source md5" > > +config U_BOOT_BUILD_OOT > + prompt "Out of tree build" > + default y > + bool > + help > + U-Boot is usually built out of tree. > + But for some builds, f.ex. with firmware blobs, out of tree builds > + can break because of vendors using source paths to files. > + This is mostly a workaround for those type of builds. > + > choice > prompt "config system" > default U_BOOT_CONFIGSYSTEM_LEGACY > diff --git a/rules/u-boot.make b/rules/u-boot.make > index 38c32bf27..2c6a1ada4 100644 > --- a/rules/u-boot.make > +++ b/rules/u-boot.make > @@ -23,9 +23,14 @@ U_BOOT_SUFFIX := tar.bz2 > U_BOOT_URL := https://ftp.denx.de/pub/u-boot/$(U_BOOT).$(U_BOOT_SUFFIX) > U_BOOT_SOURCE := $(SRCDIR)/$(U_BOOT).$(U_BOOT_SUFFIX) > U_BOOT_DIR := $(BUILDDIR)/$(U_BOOT) > -U_BOOT_BUILD_DIR := $(U_BOOT_DIR)-build > U_BOOT_DEVPKG := NO > +ifdef PTXCONF_U_BOOT_BUILD_OOT > +U_BOOT_BUILD_DIR := $(U_BOOT_DIR)-build > U_BOOT_BUILD_OOT := KEEP > +else > +U_BOOT_BUILD_DIR := $(U_BOOT_DIR) > +U_BOOT_BUILD_OOT := NO > +endif > > ifdef PTXCONF_U_BOOT_CONFIGSYSTEM_KCONFIG > U_BOOT_CONFIG := $(call ptx/in-platformconfigdir, \ > @@ -54,10 +59,13 @@ U_BOOT_WRAPPER_BLACKLIST := \ > > U_BOOT_CONF_OPT := \ > -C $(U_BOOT_DIR) \ > - O=$(U_BOOT_BUILD_DIR) \ > V=$(PTXDIST_VERBOSE) \ > $(call remove_quotes,$(PTXCONF_U_BOOT_CUSTOM_MAKE_OPTS)) > > +ifdef PTXCONF_U_BOOT_BUILD_OOT > +U_BOOT_CONF_OPT += O=$(U_BOOT_BUILD_DIR) > +endif > + > U_BOOT_MAKE_ENV := \ > CROSS_COMPILE=$(BOOTLOADER_CROSS_COMPILE) \ > HOSTCC=$(HOSTCC) LGTM. Tested-by: Alexander Dahl Greets Alex _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de