From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 30 Nov 2021 06:44:12 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mrvw4-00071u-Ua for lore@lore.pengutronix.de; Tue, 30 Nov 2021 06:44:12 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mrvw4-0000K2-LW; Tue, 30 Nov 2021 06:44:12 +0100 Received: from mail.thorsis.com ([92.198.35.195]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrvvS-0000Jt-FO for ptxdist@pengutronix.de; Tue, 30 Nov 2021 06:43:35 +0100 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id A2C87E61 for ; Tue, 30 Nov 2021 06:43:32 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f5XGQYJoDDfq for ; Tue, 30 Nov 2021 06:43:28 +0100 (CET) Received: by mail.thorsis.com (Postfix, from userid 109) id EBC3531B3; Tue, 30 Nov 2021 06:43:27 +0100 (CET) Date: Tue, 30 Nov 2021 06:43:17 +0100 From: Alexander Dahl To: Christian Melki Message-ID: Mail-Followup-To: Christian Melki , ptxdist@pengutronix.de References: <20211129194903.596814-1-christian.melki@t2data.com> <20211129194903.596814-2-christian.melki@t2data.com> Content-Disposition: inline In-Reply-To: <20211129194903.596814-2-christian.melki@t2data.com> X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,BAYES_00,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH v2] U-Boot: Add option to disable OOT builds. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hello Christian, Am Mon, Nov 29, 2021 at 08:49:03PM +0100 schrieb Christian Melki: > This option sometimes breaks builds with various external dependencies. > Especially vendor trees that have sourcedir path references. > > Signed-off-by: Christian Melki > --- > platforms/u-boot.in | 10 ++++++++++ > rules/u-boot.make | 4 +++- > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/platforms/u-boot.in b/platforms/u-boot.in > index 410391fe8..0d8213f45 100644 > --- a/platforms/u-boot.in > +++ b/platforms/u-boot.in > @@ -20,6 +20,16 @@ config U_BOOT_MD5 > string > prompt "U-Boot source md5" > > +config U_BOOT_BUILD_OOT > + prompt "Out of tree build" > + default y > + bool > + help > + U-Boot is usually built out of tree. > + But for some builds, f.ex. with firmware blobs, out of tree builds > + can break because of vendors using source paths to files. > + This is mostly a workaround for those type of builds. Fine. > + > choice > prompt "config system" > default U_BOOT_CONFIGSYSTEM_LEGACY > diff --git a/rules/u-boot.make b/rules/u-boot.make > index 38c32bf27..cb1454a89 100644 > --- a/rules/u-boot.make > +++ b/rules/u-boot.make > @@ -23,9 +23,11 @@ U_BOOT_SUFFIX := tar.bz2 > U_BOOT_URL := https://ftp.denx.de/pub/u-boot/$(U_BOOT).$(U_BOOT_SUFFIX) > U_BOOT_SOURCE := $(SRCDIR)/$(U_BOOT).$(U_BOOT_SUFFIX) > U_BOOT_DIR := $(BUILDDIR)/$(U_BOOT) > +ifeq ($(PTXCONF_U_BOOT_BUILD_OOT),y) > U_BOOT_BUILD_DIR := $(U_BOOT_DIR)-build > +endif Why not simply use 'ifdef PTXCONF_U_BOOT_BUILD_OOT' like for usual boolean options, too? > U_BOOT_DEVPKG := NO > -U_BOOT_BUILD_OOT := KEEP > +U_BOOT_BUILD_OOT := $(call ptx/ifdef, PTXCONF_U_BOOT_BUILD_OOT, KEEP, NO) Looks correct. Greets Alex > > ifdef PTXCONF_U_BOOT_CONFIGSYSTEM_KCONFIG > U_BOOT_CONFIG := $(call ptx/in-platformconfigdir, \ > -- > 2.30.2 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de