From: Alexander Dahl <ada@thorsis.com>
To: Christian Melki <christian.melki@t2data.com>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2] U-Boot: Add option to disable OOT builds.
Date: Tue, 30 Nov 2021 06:43:17 +0100 [thread overview]
Message-ID: <YaW59ScaI0pUDKlH@ada-deb-carambola.ifak-system.com> (raw)
In-Reply-To: <20211129194903.596814-2-christian.melki@t2data.com>
Hello Christian,
Am Mon, Nov 29, 2021 at 08:49:03PM +0100 schrieb Christian Melki:
> This option sometimes breaks builds with various external dependencies.
> Especially vendor trees that have sourcedir path references.
>
> Signed-off-by: Christian Melki <christian.melki@t2data.com>
> ---
> platforms/u-boot.in | 10 ++++++++++
> rules/u-boot.make | 4 +++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/platforms/u-boot.in b/platforms/u-boot.in
> index 410391fe8..0d8213f45 100644
> --- a/platforms/u-boot.in
> +++ b/platforms/u-boot.in
> @@ -20,6 +20,16 @@ config U_BOOT_MD5
> string
> prompt "U-Boot source md5"
>
> +config U_BOOT_BUILD_OOT
> + prompt "Out of tree build"
> + default y
> + bool
> + help
> + U-Boot is usually built out of tree.
> + But for some builds, f.ex. with firmware blobs, out of tree builds
> + can break because of vendors using source paths to files.
> + This is mostly a workaround for those type of builds.
Fine.
> +
> choice
> prompt "config system"
> default U_BOOT_CONFIGSYSTEM_LEGACY
> diff --git a/rules/u-boot.make b/rules/u-boot.make
> index 38c32bf27..cb1454a89 100644
> --- a/rules/u-boot.make
> +++ b/rules/u-boot.make
> @@ -23,9 +23,11 @@ U_BOOT_SUFFIX := tar.bz2
> U_BOOT_URL := https://ftp.denx.de/pub/u-boot/$(U_BOOT).$(U_BOOT_SUFFIX)
> U_BOOT_SOURCE := $(SRCDIR)/$(U_BOOT).$(U_BOOT_SUFFIX)
> U_BOOT_DIR := $(BUILDDIR)/$(U_BOOT)
> +ifeq ($(PTXCONF_U_BOOT_BUILD_OOT),y)
> U_BOOT_BUILD_DIR := $(U_BOOT_DIR)-build
> +endif
Why not simply use 'ifdef PTXCONF_U_BOOT_BUILD_OOT' like for usual
boolean options, too?
> U_BOOT_DEVPKG := NO
> -U_BOOT_BUILD_OOT := KEEP
> +U_BOOT_BUILD_OOT := $(call ptx/ifdef, PTXCONF_U_BOOT_BUILD_OOT, KEEP, NO)
Looks correct.
Greets
Alex
>
> ifdef PTXCONF_U_BOOT_CONFIGSYSTEM_KCONFIG
> U_BOOT_CONFIG := $(call ptx/in-platformconfigdir, \
> --
> 2.30.2
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2021-11-30 5:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 19:49 [ptxdist] [PATCH v2] U-Boot: Add TF-A dependency option Christian Melki
2021-11-29 19:49 ` [ptxdist] [PATCH v2] U-Boot: Add option to disable OOT builds Christian Melki
2021-11-30 5:43 ` Alexander Dahl [this message]
2021-11-30 8:04 ` Alexander Dahl
2022-02-04 8:20 ` [ptxdist] [PATCH v2] U-Boot: Add TF-A dependency option Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaW59ScaI0pUDKlH@ada-deb-carambola.ifak-system.com \
--to=ada@thorsis.com \
--cc=christian.melki@t2data.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox