Re: [ptxdist] [PATCH 1/2] pipewire: version bump 0.3.37 -> 0.3.40

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Nov 26, 2021 at 10:38:28AM +0100, Philipp Zabel wrote:
> On Thu, 2021-11-25 at 16:57 +0100, Michael Olbrich wrote:
> > On Mon, Nov 22, 2021 at 02:33:54PM +0100, Philipp Zabel wrote:
> > > - pipewire-media-session was split out into its own package
> > > - pw-cli now uses readline.
> > > 
> > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > > ---
> > >  rules/pipewire.in   |  1 +
> > >  rules/pipewire.make | 25 +++++++++----------------
> > >  2 files changed, 10 insertions(+), 16 deletions(-)
> > > 
> > > diff --git a/rules/pipewire.in b/rules/pipewire.in
> > > index c77dec87276e..2fd3025dfc12 100644
> > > --- a/rules/pipewire.in
> > > +++ b/rules/pipewire.in
> > > @@ -12,6 +12,7 @@ menuconfig PIPEWIRE
> > >  	select GSTREAMER1		if PIPEWIRE_GSTREAMER
> > >  	select GST_PLUGINS_BASE1	if PIPEWIRE_GSTREAMER
> > >  	select LIBSNDFILE
> > > +	select READLINE
> > 
> > Please make pw-cli optional. readline ist GPL-3.0 and that can be a
> > problem for some people.
> 
> readline support is an optional dependency, I'll add a PIPEWIRE_READLINE
> option.

In this case, I prefer a PIPEWIRE_PW_CTL option. That's the only tool that
uses it and it's only available when readline is found.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de