From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 26 Nov 2021 15:28:01 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mqcCn-0003lQ-Tw for lore@lore.pengutronix.de; Fri, 26 Nov 2021 15:28:01 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mqcCn-0003rO-GG; Fri, 26 Nov 2021 15:28:01 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqcCA-0003r7-Si; Fri, 26 Nov 2021 15:27:22 +0100 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1mqcCA-001BtY-T9; Fri, 26 Nov 2021 15:27:22 +0100 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1mqcC9-004WHw-8s; Fri, 26 Nov 2021 15:27:21 +0100 Date: Fri, 26 Nov 2021 15:27:21 +0100 From: Michael Olbrich To: Philipp Zabel Message-ID: Mail-Followup-To: Philipp Zabel , ptxdist@pengutronix.de References: <20211122133355.1685566-1-p.zabel@pengutronix.de> <20211122133355.1685566-2-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH 2/2] media-session: new package X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Fri, Nov 26, 2021 at 10:36:25AM +0100, Philipp Zabel wrote: > On Thu, 2021-11-25 at 17:11 +0100, Michael Olbrich wrote: > [...] > > > + select SYSTEMD if MEDIA_SESSION_SYSTEMD > [...] > > > +config MEDIA_SESSION_SYSTEMD > > > + bool > [...] > > > > > +config MEDIA_SESSION_SYSTEMD_UNIT_USER > > > + bool > > > + default y > > > + depends on INITMETHOD_SYSTEMD > > > > && SYSTEMD_UNITS_USER > > This would cause a dependency loop: > > .../rules/systemd.in:3:error: recursive dependency detected! > .../rules/systemd.in:3: symbol SYSTEMD is selected by MEDIA_SESSION_SYSTEMD > .../rules/media-session.in:21: symbol MEDIA_SESSION_SYSTEMD is selected by MEDIA_SESSION_SYSTEMD_UNIT_USER > .../rules/media-session.in:31: symbol MEDIA_SESSION_SYSTEMD_UNIT_USER depends on SYSTEMD_UNITS_USER > .../rules/systemd.in:100: symbol SYSTEMD_UNITS_USER depends on SYSTEMD > > pulseaudio.in has "default y if SYSTEMD_UNITS_USER" instead. > > dbus.in has an invisible option DBUS_SYSTEMD_USER_UNIT that depends on > SYSTEMD_UNITS_USER and DBUS_SYSTEMD_UNIT > > Should this follow either of those? Now that I think about it, just default to the corresponding PIPEWIRE option without a prompt. It's only used in combination with that anyways. Michael > [...] > > +MEDIA_SESSION_MODULES := \ > > unused? > [...] > > +MEDIA_SESSION_SPA_MODULES := \ > > unused? > > Ouch, copy&paste-from-pipewire.make error, will remove. > > [...] > > + @$(call install_copy, media-session, 0, 0, 644, -, /usr/share/pipewire/media-session.d/alsa-monitor.conf) > > + @$(call install_copy, media-session, 0, 0, 644, -, /usr/share/pipewire/media-session.d/bluez-monitor.conf) > > + @$(call install_copy, media-session, 0, 0, 644, -, /usr/share/pipewire/media-session.d/media-session.conf) > > + @$(call install_copy, media-session, 0, 0, 644, -, /usr/share/pipewire/media-session.d/v4l2-monitor.conf) > > break the lines. > > Ok. > > regards > Philipp > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de