Re: [ptxdist] [PATCH v2 6/8] dropbear: Support ecdsa keys in rc-once and init

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Oct 18, 2021 at 04:35:52PM +0200, Alexander Dahl wrote:
> With 54afea33423c ("dropbear: Added Elliptic Curve Cryptography
> options.") an option was added to built with ecdsa host key support, but
> scripts where not adapted back then.
> 
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
>  projectroot/etc/init.d/dropbear      | 3 +++
>  projectroot/etc/rc.once.d/dropbear   | 3 +++
>  projectroot/usr/lib/init/dropbear.sh | 1 +
>  3 files changed, 7 insertions(+)
> 
> diff --git a/projectroot/etc/init.d/dropbear b/projectroot/etc/init.d/dropbear
> index 88ef5aa71..f6c1fb06f 100644
> --- a/projectroot/etc/init.d/dropbear
> +++ b/projectroot/etc/init.d/dropbear
> @@ -24,6 +24,9 @@ dropbear_start() {
>                  ;;
>              rsa)
>                  test -f $DROPBEAR_RSAKEY && KEY_ARGS="$KEY_ARGS -r $DROPBEAR_RSAKEY"
> +                ;;
> +		    ecdsa)

intention

> +                [ -f "$DROPBEAR_ECDSAKEY" ] && KEY_ARGS="$KEY_ARGS -r $DROPBEAR_ECDSAKEY"

kan wie stick to one syntx: 'test' or '[' but not mixed.

Michael

>                  ;;
>              *)
>                  echo "Key type '$keytype' not supported"
> diff --git a/projectroot/etc/rc.once.d/dropbear b/projectroot/etc/rc.once.d/dropbear
> index a9a1d475c..bfebccfc4 100644
> --- a/projectroot/etc/rc.once.d/dropbear
> +++ b/projectroot/etc/rc.once.d/dropbear
> @@ -33,6 +33,9 @@ gen_keys() {
>  			rsa)
>  				gen_key rsa "$DROPBEAR_RSAKEY"
>  				;;
> +			ecdsa)
> +				gen_key ecdsa "$DROPBEAR_ECDSAKEY"
> +				;;
>  			*)
>  				echo "Key type '$keytype' not supported"
>  				;;
> diff --git a/projectroot/usr/lib/init/dropbear.sh b/projectroot/usr/lib/init/dropbear.sh
> index e8aa58576..9c9c9aef7 100644
> --- a/projectroot/usr/lib/init/dropbear.sh
> +++ b/projectroot/usr/lib/init/dropbear.sh
> @@ -2,4 +2,5 @@
>  
>  DROPBEAR_RSAKEY='@KEYDIR@/dropbear_rsa_host_key'
>  DROPBEAR_DSSKEY='@KEYDIR@/dropbear_dss_host_key'
> +DROPBEAR_ECDSAKEY='@KEYDIR@/dropbear_ecdsa_host_key'
>  DROPBEAR_KEYTYPES='@KEYTYPES@'
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de