From: Alexander Dahl <ada@thorsis.com>
To: Roland Hieber <rhi@pengutronix.de>, ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] image-rauc: allow selecting the bundle type (plain or verity)
Date: Fri, 1 Oct 2021 09:24:43 +0200 [thread overview]
Message-ID: <YVa3uyFFJdeZmK85@ada.ifak-system.com> (raw)
In-Reply-To: <20210930223442.5820-1-rhi@pengutronix.de>
Hello Roland,
nice to see this. One could have set it in a rauc.config copied to the
own BSP, but this is simpler to use.
Am Fri, Oct 01, 2021 at 12:34:42AM +0200 schrieb Roland Hieber:
> Newer setups probably want to use the improved 'verity' format, while
> existing setups probably need to stay with 'plain' to provide an upgrade
> path. See the discussion of the differences between the formats in
> <https://rauc.readthedocs.io/en/latest/reference.html#sec-ref-formats>.
>
> Reported-by: Alexander Dahl <ada@thorsis.com>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
> config/images/rauc.config | 5 ++++-
> platforms/image-rauc.in | 15 +++++++++++++++
> rules/image-rauc.make | 1 +
> 3 files changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/config/images/rauc.config b/config/images/rauc.config
> index 0c824f00e5d3..ddf40fb17054 100644
> --- a/config/images/rauc.config
> +++ b/config/images/rauc.config
> @@ -7,7 +7,10 @@ image @IMAGE@ {
> version=@RAUC_BUNDLE_VERSION@
> build=@RAUC_BUNDLE_BUILD@
> description=@RAUC_BUNDLE_DESCRIPTION@
> -
> +
> + [bundle]
> + format=@RAUC_BUNDLE_FORMAT@
> +
> [image.rootfs]
> filename=root.tar.gz
> "
> diff --git a/platforms/image-rauc.in b/platforms/image-rauc.in
> index 1f9427b40f42..3fa5dfc8c13a 100644
> --- a/platforms/image-rauc.in
> +++ b/platforms/image-rauc.in
> @@ -26,4 +26,19 @@ config IMAGE_RAUC_DESCRIPTION
> help
> Optional description that will be placed in the Bundles metadata.
>
> +choice
> + prompt "Bundle format"
> +
> +config IMAGE_RAUC_BUNDLE_FORMAT_PLAIN
> + bool "plain"
> + help
> + The old bundle format, which since rauc 1.5 is now known as 'plain'.
> +
> +config IMAGE_RAUC_BUNDLE_FORMAT_VERITY
> + bool "verity"
> + help
> + The improved 'verity' bundle format
> +
> +endchoice
> +
> endif
> diff --git a/rules/image-rauc.make b/rules/image-rauc.make
> index fe1b0e89be7c..d70114aa2b85 100644
> --- a/rules/image-rauc.make
> +++ b/rules/image-rauc.make
> @@ -29,6 +29,7 @@ ifdef PTXCONF_IMAGE_RAUC
> IMAGE_RAUC_ENV = \
> $(CODE_SIGNING_ENV) \
> RAUC_BUNDLE_COMPATIBLE="$(call remove_quotes,$(PTXCONF_RAUC_COMPATIBLE))" \
> + RAUC_BUNDLE_FORMAT="$(call ptx/ifdef,PTXCONF_IMAGE_RAUC_BUNDLE_FORMAT_VERITY,verity,plain)" \
> RAUC_BUNDLE_VERSION="$(call remove_quotes, $(PTXCONF_RAUC_BUNDLE_VERSION))" \
> RAUC_BUNDLE_BUILD=$(call ptx/sh, date +%FT%T%z) \
> RAUC_BUNDLE_DESCRIPTION=$(PTXCONF_IMAGE_RAUC_DESCRIPTION) \
Tested-by: Alexander Dahl <ada@thorsis.com>
Greets
Alex
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2021-10-01 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 22:34 Roland Hieber
2021-10-01 7:24 ` Alexander Dahl [this message]
2021-10-20 9:39 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVa3uyFFJdeZmK85@ada.ifak-system.com \
--to=ada@thorsis.com \
--cc=ptxdist@pengutronix.de \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox