mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: Felix Mellmann <flix.ptxdist@benfm.de>,
	ptxdist@pengutronix.de, Alexander Dahl <ada@thorsis.com>
Subject: Re: [ptxdist] python3-lxml: package seems to be broken due to libxslt config options
Date: Wed, 29 Sep 2021 14:32:54 +0200	[thread overview]
Message-ID: <YVRc9nBlDEoxWT/Q@ada.ifak-system.com> (raw)
In-Reply-To: <20210929121408.GH2560099@pengutronix.de>

Hello,

Am Wed, Sep 29, 2021 at 02:14:08PM +0200 schrieb Michael Olbrich:
> On Sun, Sep 05, 2021 at 03:29:47PM +0200, Felix Mellmann wrote:
> > On 03.09.21 17:36, Michael Olbrich wrote:
> > > On Wed, Sep 01, 2021 at 08:37:27PM +0200, Felix Mellmann wrote:
> > > > Hi there,
> > > > 
> > > > I've just encountered a problem when using python3-lxml on PTXdist master
> > > > branch:
> > > > 
> > > > $ python3
> > > > Python 3.7.10 (default, Aug  1 2021, 00:00:00)
> > > > [GCC 10.2.1 20200822] on linux
> > > > Type "help", "copyright", "credits" or "license" for more information.
> > > > > > > from lxml import etree
> > > > Traceback (most recent call last):
> > > >    File "<stdin>", line 1, in <module>
> > > > ImportError:
> > > > /usr/lib/python3.7/site-packages/lxml/etree.cpython-37m-x86_64-linux-gnu.so:
> > > > undefined symbol: xsltGetProfileInformation
> > > > 
> > > > The problem arises through libxslt which is configured using
> > > > "--without-profiler" since commit 1940c3 .
> > > > 
> > > > Removing this option again allows to at least import etree from lxml. I
> > > > haven't done any investigation whether lxml may crash again elsewhere.
> > > > 
> > > > Are there any concerns about removing that configuration option again?
> > > You should probably change it to --with-profiler instead unless that's
> > > broken. Otherwise, I have no objections.
> > 
> > Maybe Alexander had reasons to add "--without-profiler" without any
> > configuration option. He added three more options within the same patch but
> > left only this one fixed to "without".
> > 
> > So the compromise could be to add a new configuration option with default
> > value of "n" and add this configuration option as a dependency to
> > python3-lxml?
> > 
> > But as long as we don't know Alexander's reasons to do so, compiling with
> > the profiler option could break something else.
> 
> So lets ask him: Alex, can you comment on this? Did you have a reason other
> than just disabling it because it seemed unnecessary?

I just checked diff between ./configure output of libxslt 1.1.29 and
1.1.34 and this is part of it:

+  --with-profiler        Add the profiling support (on)

This means the option was new and I probably just set it to some
default.  So yes, my reasoning was most probably it just seemed
unnecessary to me.  If you need it set to --with-profiler or made
optional, go ahead the way Michael suggested.

Greets
Alex

> 
> Michael
> 
> > > Please add a comment about breaking python3-lxml at runtime, so we know in
> > > the future why this was changed.
> > > 
> > > Michael
> > > 
> > 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


  reply	other threads:[~2021-09-29 12:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 18:37 Felix Mellmann
2021-09-03 15:36 ` Michael Olbrich
2021-09-05 13:29   ` Felix Mellmann
2021-09-29 12:14     ` Michael Olbrich
2021-09-29 12:32       ` Alexander Dahl [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-09-01 18:36 Felix Mellmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVRc9nBlDEoxWT/Q@ada.ifak-system.com \
    --to=ada@thorsis.com \
    --cc=flix.ptxdist@benfm.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox