From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 04 Jan 2023 22:17:50 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pDB8x-001oyS-9b for lore@lore.pengutronix.de; Wed, 04 Jan 2023 22:17:50 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pDB8u-0007tJ-Uf; Wed, 04 Jan 2023 22:17:48 +0100 Received: from h2.cmg1.smtp.forpsi.com ([81.2.195.163]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDB8O-0007se-9g for ptxdist@pengutronix.de; Wed, 04 Jan 2023 22:17:17 +0100 Received: from lenoch ([91.218.190.200]) by cmgsmtp with ESMTPSA id DB8KpPfHUPm6CDB8MpGvc9; Wed, 04 Jan 2023 22:17:14 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triops.cz; s=f2019; t=1672867034; bh=Yio03PeLPK4q0a++zxCcP7PEQG6Bz1Ao64YtKpaJ9KE=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=blnQWk42rmnXgRan1TaNlylnvQEtwf+s1Zx5yOD9fQDOZqlPfF/inFAWMUTZlSLMC ZnCxw0dRxBAYRyfBnt6Ao/qqePqE612eRZoxN+8Nuky2rGA5SngN2U6CnewdMpFgrY um3KtdX1ZqU/h4NI92bKwBLZ9sCQG5OPllm5vuSn0MQofjDZZ+5RNqKocwyDCp68nI h702NT0hnMB4wvfkHfOcDrk+wUFKKu8OeupFOyLFScleQqyUAjahbbVXSVbvmt7tkE sEdKEDTYcb0eElxTeMoTwqAFJt1NSfOrGvB0fdA2oo5E9z9l4WRusY4en1+03fd83B 0fBv8K4x+D/nw== Date: Wed, 4 Jan 2023 22:17:12 +0100 From: Ladislav Michl To: ptxdist@pengutronix.de Message-ID: References: <20230104091433.2419958-1-christian.melki@t2data.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CMAE-Envelope: MS4wfAZ2GN3XqZqrtSOAkkqqsNZazAmmywFblYnXpqJfsTJFGMkxp2BD2FvDIieb9hiKxqRnm7FxLvW6rOhuBWDvHwhJ83yBN7fv4nQB7Ts2wjhQI+38oTPu sCH54QKTs6kV8NALnd4IXvihHCA75WdIaQJnwyvUkWMDn/y2Ay4VubdR X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.2 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH v2] busybox: Version bump. 1.35.0 -> 1.36.0 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Wed, Jan 04, 2023 at 10:23:41AM +0100, Ladislav Michl wrote: > On Wed, Jan 04, 2023 at 10:14:33AM +0100, Christian Melki wrote: > > +config BUSYBOX_UDHCPC6_DEFAULT_SCRIPT > > + string "Absolute path to config script for IPv6" > > + default "/usr/share/udhcpc/default6.script" > > + depends on BUSYBOX_UDHCPC6 > > + > > This probably needs > +ifdef PTXCONF_BUSYBOX_UDHCPC6 > + @$(call install_alternative, busybox, 0, 0, 0754, /etc/udhcpc6.script) > ... > in rules/busybox.make > > Thinking more about it, we should probably take BUSYBOX_UDHCPC_DEFAULT_SCRIPT > and BUSYBOX_UDHCPC6_DEFAULT_SCRIPT into account when installing links, but as > nobody complained so far, let it be optional separate patch :) After some discussion on IRC, let me provide some summary. As both IPv4 and IPv6 script version can point to the same file (and buildroot actually provides such common file), there is no need to complicate things right now. Just wait for actual need of separate scripts. With that in mind: Tested-by: Ladislav Michl