From: Ladislav Michl <oss-lists@triops.cz>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2] busybox: Version bump. 1.35.0 -> 1.36.0
Date: Wed, 4 Jan 2023 22:17:12 +0100 [thread overview]
Message-ID: <Y7Xs2ISHy6TFj1hk@lenoch> (raw)
In-Reply-To: <Y7VFnTH5APTvhId/@lenoch>
On Wed, Jan 04, 2023 at 10:23:41AM +0100, Ladislav Michl wrote:
> On Wed, Jan 04, 2023 at 10:14:33AM +0100, Christian Melki wrote:
> > +config BUSYBOX_UDHCPC6_DEFAULT_SCRIPT
> > + string "Absolute path to config script for IPv6"
> > + default "/usr/share/udhcpc/default6.script"
> > + depends on BUSYBOX_UDHCPC6
> > +
>
> This probably needs
> +ifdef PTXCONF_BUSYBOX_UDHCPC6
> + @$(call install_alternative, busybox, 0, 0, 0754, /etc/udhcpc6.script)
> ...
> in rules/busybox.make
>
> Thinking more about it, we should probably take BUSYBOX_UDHCPC_DEFAULT_SCRIPT
> and BUSYBOX_UDHCPC6_DEFAULT_SCRIPT into account when installing links, but as
> nobody complained so far, let it be optional separate patch :)
After some discussion on IRC, let me provide some summary.
As both IPv4 and IPv6 script version can point to the same file (and buildroot
actually provides such common file), there is no need to complicate things
right now. Just wait for actual need of separate scripts. With that in mind:
Tested-by: Ladislav Michl <ladis@linux-mips.org>
next prev parent reply other threads:[~2023-01-04 21:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:14 Christian Melki
2023-01-04 9:23 ` Ladislav Michl
2023-01-04 21:17 ` Ladislav Michl [this message]
2023-01-06 11:17 ` Ladislav Michl
2023-01-06 11:19 ` Michael Olbrich
2023-01-06 11:24 ` Ladislav Michl
2023-01-06 16:01 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7Xs2ISHy6TFj1hk@lenoch \
--to=oss-lists@triops.cz \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox