Re: [ptxdist] [PATCH 1/2] paho-mqtt-c.make: add missing libraries

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Dec 27, 2022 at 08:03:15AM +0100, Robert Schwebel wrote:
> The build system creates a client library (c) and an async library (a),
> both in a non-SSL and SSL variant. Let's install all of them, as we
> don't know which ones are needed.
> 
> Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
> ---
>  rules/paho-mqtt-c.make | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/rules/paho-mqtt-c.make b/rules/paho-mqtt-c.make
> index 8e229cfe2..143433128 100644
> --- a/rules/paho-mqtt-c.make
> +++ b/rules/paho-mqtt-c.make
> @@ -51,7 +51,14 @@ $(STATEDIR)/paho-mqtt-c.targetinstall:
>  	@$(call install_fixup, paho-mqtt-c,AUTHOR,"Marc Kleine-Budde <mkl@pengutronix.de>")
>  	@$(call install_fixup, paho-mqtt-c,DESCRIPTION,missing)
>  
> +	# async library without ssh

This is a shell comment and not a make comment and it shows up in the log
at an unexpected time because install_lib just collects the command that is
executed in install_finish.

Make it a make comment with:

#	# async library without ssh

Same for the others.

Michael

> +	@$(call install_lib, paho-mqtt-c, 0, 0, 0644, libpaho-mqtt3a)
> +	# async library with ssh
>  	@$(call install_lib, paho-mqtt-c, 0, 0, 0644, libpaho-mqtt3as)
> +	# client library without ssl
> +	@$(call install_lib, paho-mqtt-c, 0, 0, 0644, libpaho-mqtt3c)
> +	# client library with ssl
> +	@$(call install_lib, paho-mqtt-c, 0, 0, 0644, libpaho-mqtt3cs)
>  
>  	@$(call install_finish, paho-mqtt-c)
>  
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |