From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 15 Dec 2022 09:33:53 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p5jge-004V8E-KU for lore@lore.pengutronix.de; Thu, 15 Dec 2022 09:33:53 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1p5jge-0000dB-15; Thu, 15 Dec 2022 09:33:52 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5jgQ-0000cx-JD; Thu, 15 Dec 2022 09:33:38 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1p5jgP-004f5O-6Q; Thu, 15 Dec 2022 09:33:37 +0100 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1p5jgP-00B9wZ-9c; Thu, 15 Dec 2022 09:33:37 +0100 Date: Thu, 15 Dec 2022 09:33:37 +0100 From: Michael Olbrich To: Roland Hieber Message-ID: Mail-Followup-To: Roland Hieber , ptxdist@pengutronix.de References: <20221212221726.3643397-1-rhi@pengutronix.de> <20221212221726.3643397-2-rhi@pengutronix.de> <20221212222655.h6zidsrr2pn6qreb@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221212222655.h6zidsrr2pn6qreb@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH v3 2/2] binutils: add license information X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Mon, Dec 12, 2022 at 11:26:55PM +0100, Roland Hieber wrote: > On Mon, Dec 12, 2022 at 11:17:26PM +0100, Roland Hieber wrote: > > Only readelf and objdump are installed to the target, but they are > > statically linked to the bundled zlib, libbfd, libctf, libiberty, and > > libopcodes, which don't have the same licenses. Try a divide-and-conquer > > strategy here to keep the clarity. > > > > libiberty includes an "unknown" portion in libiberty/xatexit.c, which > > only carries the following lines: > > > > | /* > > | * Copyright (c) 1990 Regents of the University of California. > > | * All rights reserved. > > | * > > | * %sccs.include.redist.c% > > | */ > > > > Reported-by: Felicitas Jung > > Signed-off-by: Roland Hieber > > --- > > PATCH v3: > > - unravel the sub-libs into clearly arranged license statements > > - this is the last patch that remained open from the original PULL v1. > > > > PATCH v2: https://lore.ptxdist.org/ptxdist/20211205004208.2306245-13-rhi@pengutronix.de > > - use "custom-exception" instead of "unknown" > > - rebase to current master, review and adapt MD5 sums accordingly > > > > PULL v1: https://lore.ptxdist.org/ptxdist/20200527112204.ll7ij44ahllid6ip@pengutronix.de > > --- > > rules/binutils.make | 56 +++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 56 insertions(+) > > > > diff --git a/rules/binutils.make b/rules/binutils.make > > index 20bb5d60f700..aed4d9226b35 100644 > > --- a/rules/binutils.make > > +++ b/rules/binutils.make > > @@ -23,6 +23,62 @@ BINUTILS_URL := $(call ptx/mirror, GNU, binutils/$(BINUTILS).$(BINUTILS_SUFFIX) > > BINUTILS_SOURCE := $(SRCDIR)/$(BINUTILS).$(BINUTILS_SUFFIX) > > BINUTILS_DIR := $(BUILDDIR)/$(BINUTILS) > > Oh my. I just discovered that the binutils version depends on the > toolchain version too, so this patch only works cleanly with > OSELAS.Toolchain 2022.10.0 which brings us binutils 2.39 … > > So I guess we need to find a similar versioning strategy for the license > variables, as with the kernel package. I think, something like what we do for glibc would make sense: Provide a file to include with the toolchain for the simple case. For toolchains that don't have it yet, I think a rules/binutils.license.make is needed in the BSP. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |