[ptxdist] [PATCH] gdb: add option for 11.1 and later

[ptxdist] [PATCH] gdb: add option for 11.1 and later

[Philipp Zabel]

GDB requires GMP since version 11.1. Add an option to allow selecting
LIBGMP for newer toolchains. This is somewhat analogous to commit
bc5cac5c54d2 ("glibc: add option for 2.34 and later").

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 rules/gdb.in | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/rules/gdb.in b/rules/gdb.in
index 1dd2213abc8a..3014271de9c1 100644
--- a/rules/gdb.in
+++ b/rules/gdb.in
@@ -7,6 +7,7 @@ menuconfig GDB
 	select LIBC_DL
 	select GCCLIBS_GCC_S
 	select NCURSES
+	select LIBGMP		if GDB_11_1
 	help
 	  The GNU Debugger
 
@@ -25,5 +26,12 @@ config GDB_SHARED
 	  If not set, the build option
 	  LDFLAGS=-static will be activated.
 
+config GDB_11_1
+	bool
+	prompt "gdb-11.1 or later"
+	help
+	  Since gdb-11.1, GMP is a required dependency. Enable this option
+	  if your toolchain gdb version is 11.1 or later.
+
 endif
 
-- 
2.30.2

Re: [ptxdist] [PATCH] gdb: add option for 11.1 and later

[Ladislav Michl]

Hi Philipp!

On Thu, Nov 03, 2022 at 05:55:42PM +0100, Philipp Zabel wrote:
> GDB requires GMP since version 11.1. Add an option to allow selecting
> LIBGMP for newer toolchains. This is somewhat analogous to commit
> bc5cac5c54d2 ("glibc: add option for 2.34 and later").

before adding one more analogous commit, what about turning both of
them to something like
	def_bool $(success,test "you_test_goes_there")


> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  rules/gdb.in | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/rules/gdb.in b/rules/gdb.in
> index 1dd2213abc8a..3014271de9c1 100644
> --- a/rules/gdb.in
> +++ b/rules/gdb.in
> @@ -7,6 +7,7 @@ menuconfig GDB
>  	select LIBC_DL
>  	select GCCLIBS_GCC_S
>  	select NCURSES
> +	select LIBGMP		if GDB_11_1
>  	help
>  	  The GNU Debugger
>  
> @@ -25,5 +26,12 @@ config GDB_SHARED
>  	  If not set, the build option
>  	  LDFLAGS=-static will be activated.
>  
> +config GDB_11_1
> +	bool
> +	prompt "gdb-11.1 or later"
> +	help
> +	  Since gdb-11.1, GMP is a required dependency. Enable this option
> +	  if your toolchain gdb version is 11.1 or later.
> +
>  endif
>  
> -- 
> 2.30.2
> 

Re: [ptxdist] [APPLIED] gdb: add option for 11.1 and later

[Michael Olbrich]

Thanks, applied as 09e0190646c7f46c15c8e084dd6810c1246db46e.

Michael

[sent from post-receive hook]

On Fri, 11 Nov 2022 15:31:22 +0100, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> GDB requires GMP since version 11.1. Add an option to allow selecting
> LIBGMP for newer toolchains. This is somewhat analogous to commit
> bc5cac5c54d2 ("glibc: add option for 2.34 and later").
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Message-Id: <20221103165542.469895-1-p.zabel@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/gdb.in b/rules/gdb.in
> index 1dd2213abc8a..3014271de9c1 100644
> --- a/rules/gdb.in
> +++ b/rules/gdb.in
> @@ -7,6 +7,7 @@ menuconfig GDB
>  	select LIBC_DL
>  	select GCCLIBS_GCC_S
>  	select NCURSES
> +	select LIBGMP		if GDB_11_1
>  	help
>  	  The GNU Debugger
>  
> @@ -25,5 +26,12 @@ config GDB_SHARED
>  	  If not set, the build option
>  	  LDFLAGS=-static will be activated.
>  
> +config GDB_11_1
> +	bool
> +	prompt "gdb-11.1 or later"
> +	help
> +	  Since gdb-11.1, GMP is a required dependency. Enable this option
> +	  if your toolchain gdb version is 11.1 or later.
> +
>  endif
>