From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Tue, 18 Oct 2022 15:15:03 +0200
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1okmQy-00Cd1v-Fm
	for lore@lore.pengutronix.de; Tue, 18 Oct 2022 15:15:03 +0200
Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de)
	by metis.ext.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1okmQw-0006qn-PL; Tue, 18 Oct 2022 15:15:02 +0200
Received: from h1.cmg1.smtp.forpsi.com ([81.2.195.162])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <oss-lists@triops.cz>) id 1okmQr-0006fr-JI
 for ptxdist@pengutronix.de; Tue, 18 Oct 2022 15:14:57 +0200
Received: from lenoch ([91.218.190.200]) by cmgsmtp with ESMTPSA
 id kmQqokjxAPm6CkmQro0e28; Tue, 18 Oct 2022 15:14:57 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triops.cz; s=f2019;
 t=1666098897; bh=dziITlf3xYlejhhEWQ9CrB3B2oS2CwSIKxlvGwR/TlE=;
 h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type;
 b=I9PK4dw/dhxbUqkIYH/gXsPvoIV75juOXwLaLmjPRiGIhkJsCji64M1NLcgExlIH3
 2XixbIFJb0MzrWV65ipUbEbcCl+BUuwOkSbJ0fRMUsbCOeyLLlzC8TtajamYAKwyoU
 ZCEitnPi6MSuHfRtN5xy30uMkFmpfusHyDzDMiJTjgTs9OWwYLnRin0sWrHeS3GVE9
 0X1Gehdtfa7dIyTNJlnkcGRJOEuCJpAjkX2diJNqcsCf4IcVlFu41b3Zl/PshZgz7a
 nzib16WHQ0adfEStC+5Lw3qe+M5ocbAI4fsQXDNSa/exdUydRKqItFEzcVVFmrJWzF
 IcO8TF2Kd/xqA==
Date: Tue, 18 Oct 2022 15:14:51 +0200
From: Ladislav Michl <oss-lists@triops.cz>
To: ptxdist@pengutronix.de
Message-ID: <Y06myyuO4QTDUgwn@lenoch>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-CMAE-Envelope: MS4wfCeWv/M7FehOlgehDpeNAJB+++XXb2j5ILae11UVYshHa9FDpOVw1RZmdi/w76KdJ3uuZS+qMLJj8O3cjaUf7RMXzXzW74IkeFCd3Y36rMHGbaf7/MwG
 kwXYWn3r/FFmzPZW1uiHLK3N/BU7iG+vZq1Rgxdb7kZzl0FhV1RXM5jz
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 metis.ext.pengutronix.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,
 SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2
Subject: [ptxdist] [RFC] ptxd_make_world_common: optionally bailout on
 deprecated variable use
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false

From: Ladislav Michl <ladis@linux-mips.org>

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 This is aimed as helper for those willing to remove deprecated
 variables.
 Most of them are gone now, but a few <PKG>_ENV is still there.
 You may use (regexp provided by Uwe Kleine-König)
   grep -rPe '(?<!_CONF|MAKE)_ENV(?![)_])'
 to look for them

 config/setup/Kconfig                  |  6 ++++++
 scripts/lib/ptxd_make_world_common.sh | 15 ++++++++++++++-
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/config/setup/Kconfig b/config/setup/Kconfig
index 0a7db1678..f1a31e792 100644
--- a/config/setup/Kconfig
+++ b/config/setup/Kconfig
@@ -304,6 +304,12 @@ config SETUP_CHECK_EXIT_ON_ERROR
 	  quite aggressive error checking. Don't turn this on until
 	  you know what you're doing.
 
+config SETUP_DEPRECATED_FATAL
+	bool "bailout on deprecated variable use"
+	help
+	  Terminate on deprecated variable use. Turn this on only
+          if you are going to hunt for deprecated variables.
+
 config SETUP_ICECC
 	bool "use icecc"
 	depends on !SETUP_CCACHE
diff --git a/scripts/lib/ptxd_make_world_common.sh b/scripts/lib/ptxd_make_world_common.sh
index db24af99f..f72221076 100644
--- a/scripts/lib/ptxd_make_world_common.sh
+++ b/scripts/lib/ptxd_make_world_common.sh
@@ -20,6 +20,15 @@ ptxd_make_world_init_deprecation_check() {
 	pkg_deprecated_compile_env
 	pkg_deprecated_makevars
 	)
+    local -a depname
+    depname=(
+	BUILDDIR
+	ENV
+	AUTOCONF
+	CMAKE
+	COMPILE_ENV
+	MAKEVARS
+	)
     local i
 
     for ((i = 0; i < ${#dep[@]}; i++)); do
@@ -28,8 +37,12 @@ ptxd_make_world_init_deprecation_check() {
 
 	[ -z "${val}" ] && continue
 
-	echo "${var}=\"${val}\""
+	echo "<PKG>_${depname[i]}: ${var}=\"${val}\""
 	echo
+
+	if [ "${PTXCONF_SETUP_DEPRECATED_FATAL}" = "y" ]; then
+	    ptxd_bailout "${FUNCNAME}: deprecated variable <PKG>_${depname[i]} detected!"
+	fi
     done
 
 }
-- 
2.32.0