From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 18 Oct 2022 10:17:00 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1okhmW-00CRlm-Tb for lore@lore.pengutronix.de; Tue, 18 Oct 2022 10:17:00 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1okhmU-0006XF-C3; Tue, 18 Oct 2022 10:16:58 +0200 Received: from h2.cmg2.smtp.forpsi.com ([81.2.195.189]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okhmD-0006Ww-J3 for ptxdist@pengutronix.de; Tue, 18 Oct 2022 10:16:41 +0200 Received: from lenoch ([91.218.190.200]) by cmgsmtp with ESMTPSA id khmBoAcf7v5uIkhmCoiwLl; Tue, 18 Oct 2022 10:16:40 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triops.cz; s=f2019; t=1666081000; bh=+0D7RkB9arC7hnQT+MOgss4UAQt10HtCeFw59uKPoyA=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=B33x1FO8xEJW06cS7E6WuPX/pYNm+exZv7NaFBSXXsWpe+tfJicR+GpzkCc/V9Cq6 5ZeesZKhbHOy4GeOw7J0Z3elnUV3MbZmLMMNluzPLDKw8pocOWPBEmqxM8cRKbO94f ZTdyTBB02CKjWGETAs+KY73Z1UwwxQMciwqDYm6jfM2+C9kdLCr1BGFosERNdlkb2h z3Uc9yN0QLyDZNwkqeuZHsCH0aHKDflZpybg45PNUWTgKEedeg/mCqFjEWrKTkwgXO Kaso5vdsHzCoJ4gCzYQBviKzTQnhJSelProaDwhsspQy49nPgV5s+UubDirgprIXxf 7DwR1j1vcTYXQ== Date: Tue, 18 Oct 2022 10:16:34 +0200 From: Ladislav Michl To: ptxdist@pengutronix.de Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CMAE-Envelope: MS4wfFqnh0PSZokkCc7GYrnNnyzqXo0kUrH++/ulizpd8XO1I+iDWW7UMj/LxTIWtBNqanqbBkrI4GHTcvehio3qlx2FP3reNVspfVFVMzWhQbgQNH6zSUQV 5mOnJxxJeKHJLt9QiFIq27KhZgLtleTT5Fo3aOcHZ4rIj4IBFd6gQeED X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 1/3] rules: Remove default assignments to _PATH and _ENV X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Tue, Oct 18, 2022 at 09:48:34AM +0200, Michael Olbrich wrote: > On Mon, Oct 17, 2022 at 09:59:04PM +0200, Ladislav Michl wrote: > > From: Ladislav Michl > > > > Undefined _PATH is set to PATH=$(CROSS_PATH) for target packages, > > PATH=$(HOST_PATH) for host packages and PATH=$(HOST_CROSS_PATH) for > > cross packages. > > > > Undefined _ENV is set to $(CROSS_ENV) for target packages, > > $(HOST_ENV) for host packages and $(HOST_CROSS_ENV) for cross > > packages. > > Hmmm, _ENV is also used in the install stage and it has no default > here. But it's not used in the compile stage. In general I think those two > stages should have the default environment. So if this breaks something, > then it was probably somewhat broken anyways. > I'll throw in in my 'build everything' test. Let's see what happens here. Thank you, it was meant as preparation for _AUTOCONF removal patch where _CONF_ENV is used when needed. _AUTOCONF and _ENV are two heavily used deprecated variables. There are few _MAKEVARS and _COMPILE_ENV left. I can prepare patch to replace them, so we can bail out with error after some transitional period. l. > Michael