Re: [ptxdist] [PATCH 1/3] rules: Remove default assignments to <PKG>_PATH and <PKG>_ENV

[Ladislav Michl <oss-lists@triops.cz>]

On Tue, Oct 18, 2022 at 09:48:34AM +0200, Michael Olbrich wrote:
> On Mon, Oct 17, 2022 at 09:59:04PM +0200, Ladislav Michl wrote:
> > From: Ladislav Michl <ladis@linux-mips.org>
> > 
> > Undefined <PKG>_PATH is set to PATH=$(CROSS_PATH) for target packages,
> > PATH=$(HOST_PATH) for host packages and PATH=$(HOST_CROSS_PATH) for
> > cross packages.
> > 
> > Undefined <PKG>_ENV is set to $(CROSS_ENV) for target packages,
> > $(HOST_ENV) for host packages and $(HOST_CROSS_ENV) for cross
> > packages.
> 
> Hmmm, <PKG>_ENV is also used in the install stage and it has no default
> here. But it's not used in the compile stage. In general I think those two
> stages should have the default environment. So if this breaks something,
> then it was probably somewhat broken anyways.
> I'll throw in in my 'build everything' test. Let's see what happens here.

Thank you,

it was meant as preparation for <PKG>_AUTOCONF removal patch where
<PKG>_CONF_ENV is used when needed. <PKG>_AUTOCONF and <PKG>_ENV 
are two heavily used deprecated variables. There are few <PKG>_MAKEVARS
and <PKG>_COMPILE_ENV left.

I can prepare patch to replace them, so we can bail out with error after
some transitional period.

	l.

> Michael