Re: [ptxdist] [PATCH] machine-id: make using rc-once optional

[Ladislav Michl <ladis@linux-mips.org>]

On Fri, Nov 27, 2020 at 09:38:41AM +0100, Michael Olbrich wrote:
> On Wed, Nov 25, 2020 at 05:56:49PM +0100, Artur Wiebe wrote:
> > If not set only an empty /etc/machine-id will be installed.
> > 
> > Signed-off-by: Artur Wiebe <artur@4wiebe.de>
> > ---
> >  rules/machine-id.in       | 22 ++++++++++++++++++----
> >  rules/machine-id.make     |  4 ++++
> >  rules/machine-id.postinst |  5 +++--
> >  3 files changed, 25 insertions(+), 6 deletions(-)
> > 
> > diff --git a/rules/machine-id.in b/rules/machine-id.in
> > index f18fec554..2a3901f41 100644
> > --- a/rules/machine-id.in
> > +++ b/rules/machine-id.in
> > @@ -1,11 +1,25 @@
> >  ## SECTION=initmethod
> >  
> > -config MACHINE_ID
> > +menuconfig MACHINE_ID
> >  	tristate
> >  	prompt "create /etc/machine-id"
> > -	select RC_ONCE			if RUNTIME
> > -	select UTIL_LINUX_NG		if !INITMETHOD_SYSTEMD
> > -	select UTIL_LINUX_NG_UUIDGEN	if !INITMETHOD_SYSTEMD
> > +	select RC_ONCE			if MACHINE_ID_RC_ONCE && RUNTIME
> > +	select UTIL_LINUX_NG		if MACHINE_ID_RC_ONCE && !INITMETHOD_SYSTEMD
> > +	select UTIL_LINUX_NG_UUIDGEN	if MACHINE_ID_RC_ONCE && !INITMETHOD_SYSTEMD
> >  	help
> >  	  Enable this to make sure there is always a unique /etc/machine-id
> >  	  available in the system.
> > +
> > +if MACHINE_ID
> > +
> > +config MACHINE_ID_RC_ONCE
> > +	bool "generate (bbinit) or save (systemd) machine-id using rc-once at first boot"
> > +	default y
> 
> Hmmm, maybe should have no prompt and 'depends on RC_ONCE' (instead of
> selecting it above). I don't think there is a use-case for not persisting
> the machine-id if rc-once is available.

Well, one of my systems has a service for that. Machine-id is generated using
hardware info. In that case I do not mind as RC_ONCE is not selected, but there
is a use-case in general. However it is still possible to override
rules/machine-id.in in BSP, so...

> This is different from the ssh server key case: There are other ways to
> create the keys.

There are other ways to create machine-id too...

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de