From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from snt0-omc4-s23.snt0.hotmail.com ([65.55.90.226]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1SUmRh-0001KO-EN for ptxdist@pengutronix.de; Thu, 17 May 2012 00:12:10 +0200 Message-ID: From: barhoumi mohtadi Date: Wed, 16 May 2012 23:11:38 +0100 In-Reply-To: <201205161958.09191.jbe@pengutronix.de> References: , <201205161958.09191.jbe@pengutronix.de> MIME-Version: 1.0 Subject: Re: [ptxdist] My first Contribution! libpphidget rules :D Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1457644553==" Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de --===============1457644553== Content-Type: multipart/alternative; boundary="_98391b13-7500-44cf-9dc5-18c206bc472e_" --_98391b13-7500-44cf-9dc5-18c206bc472e_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Juergen=2C I'll add the dependencies monday at work!Thanks again for your help on this= ! Regards=2C > From: jbe@pengutronix.de > To: ptxdist@pengutronix.de > Date: Wed=2C 16 May 2012 19:58:09 +0200 > CC: mohtadi_barhoumi@hotmail.fr > Subject: Re: [ptxdist] My first Contribution! libpphidget rules :D >=20 > Hi Mohtadi=2C >=20 > barhoumi mohtadi wrote: > > Well=2C libphidget provides a set of "plug and play" building blocks fo= r low > > cost USB sensing and control from your PC. I've needed it to recognize = and > > work with an acceleromter i'm testing. Just providing it in case someon= e > > else need it :D > > > > Thanks for your remarks and suggestions! >=20 > Okay=2C lets start the review process... >=20 > > libphiget.make > > > > # -*-makefile-*- > > # > > # Copyright (C) 2012 by Mohtadi Barhoumi > > # > > # See CREDITS for details about who has contributed to this project. > > # > > # For further information about the PTXdist project and license conditi= ons > > # see the README file. > > # > > > > # > > # We provide this package > > # > > PACKAGES-$(PTXCONF_LIBPHIDGET) +=3D libphidget > > > > # > > # Paths and names > > # > > LIBPHIDGET_VERSION :=3D 2.1.8.20120514 > > LIBPHIDGET_MD5 :=3D >=20 > Please add the MD5 sum here. >=20 > > LIBPHIDGET :=3D libphidget_$(LIBPHIDGET_VERSION) > > LIBPHIDGET_SUFFIX :=3D tar.gz > > LIBPHIDGET_URL :=3D http://www.phidgets.com/downloads/libraries/= $(LIBPHIDGET).$(LIBPHIDGET_SUFFIX) LIBPHIDGET_SOURCE :=3D $(SRCDIR)/$(LI= BPHIDGET). > $(LIBPHIDGET_SUFFIX) > > LIBPHIDGET_DIR :=3D $(BUILDDIR)/$(LIBPHIDGET) > > LIBPHIDGET_LICENSE :=3D unknown >=20 > Please add the license of this package here. >=20 > > # ---------------------------------------------------------------------= ------- > > # Get=20 > > # ---------------------------------------------------------------------= ------- > > > > #$(LIBPHIDGET_SOURCE): > > # @$(call targetinfo) > > # @$(call get=2C LIBPHIDGET) >=20 > Its completely commented out. Why not remove it? >=20 > > # ---------------------------------------------------------------------= ------- > > # Prepare=20 > > # ---------------------------------------------------------------------= ------- > > > > #LIBPHIDGET_CONF_ENV :=3D $(CROSS_ENV) > > > > # > > # autoconf > > # > > LIBPHIDGET_CONF_TOOL :=3D autoconf > > #LIBPHIDGET_CONF_OPT :=3D $(CROSS_AUTOCONF_USR) > > > > #$(STATEDIR)/libphidget.prepare: > > # @$(call targetinfo) > > # @$(call clean=2C $(LIBPHIDGET_DIR)/config.cache) > > # cd $(LIBPHIDGET_DIR) && \ > > # $(LIBPHIDGET_PATH) $(LIBPHIDGET_ENV) \ > > # ./configure $(LIBPHIDGET_CONF_OPT) > > # @$(call touch) >=20 > Are you really happy with the default configure parameters? Maybe there i= s > something this package is depending on=2C and if you do not enable or dis= able > it here it depends on the build order if some smart configure scripts gue= ss if > they should compile in component X or Y... > To get a reliable result=2C you should check the external dependencies an= d add > them here or in the corresponding *.in file >=20 > A quick look to the output of "configure --help" shows at least these par= ameters > you should handle with care: >=20 > --enable-jni Compile in Java support > --enable-debug Turn on debugging > --enable-zeroconf Turn on zeroconf=2C choose avahi or bonjour > --enable-zeroconf-lookup Turn on zeroconf lookup > --enable-labview Turn on Labview support > --enable-oldlibusb Use libusb-0.1 instead of 1.0 >=20 > > # ---------------------------------------------------------------------= ------- > > # Compile=20 > > # ---------------------------------------------------------------------= ------- > > > > #$(STATEDIR)/libphidget.compile: > > # @$(call targetinfo) > > # @$(call world/compile=2C LIBPHIDGET) > > # @$(call touch) >=20 > Its completely commented out. Why not remove it? >=20 > > # ---------------------------------------------------------------------= ------- > > # Install=20 > > # ---------------------------------------------------------------------= ------- > > > > #$(STATEDIR)/libphidget.install: > > # @$(call targetinfo) > > # @$(call world/install=2C LIBPHIDGET) > > # @$(call touch) >=20 > Same here. >=20 > > # ---------------------------------------------------------------------= ------- > > # Target-Install=20 > > # ---------------------------------------------------------------------= ------- > > > > $(STATEDIR)/libphidget.targetinstall: > > @$(call targetinfo) > > > > @$(call install_init=2C libphidget) > > @$(call install_fixup=2C libphidget=2CPRIORITY=2Coptional) > > @$(call install_fixup=2C libphidget=2CSECTION=2Cbase) > > @$(call install_fixup=2C libphidget=2CAUTHOR=2C"Mohtadi Barhoumi ") > > @$(call install_fixup=2C libphidget=2CDESCRIPTION=2C) > > > > @$(call install_lib=2C libphidget=2C 0=2C 0=2C 0644=2C libphidget21= ) > > > > @$(call install_finish=2C libphidget) > > > > @$(call touch) > > > > # ---------------------------------------------------------------------= ------- > > # Clean=20 > > # ---------------------------------------------------------------------= ------- > > > > #$(STATEDIR)/libphidget.clean: > > # @$(call targetinfo) > > # @$(call clean_pkg=2C LIBPHIDGET) >=20 > Same here. >=20 > > # vim: syntax=3Dmake > > > > libphidget.in > > > > ## SECTION=3Dsystem_libraries > > > > config LIBPHIDGET > > tristate > > prompt "libphidget" > > help > > Phidgets are a set of plug and play building blocks for low > > cost USB sensing and control from your PC. >=20 > The "--enable-oldlibusb" configure parameter presents at least a dependen= cy to > the LIBUSB. Or the LIBUSB_COMPAT=2C depending on the parameter itself. >=20 > Without considering this dependency=2C your package may fail at build-tim= e. You > must tell PTXdist to build the libusb/libusbcompat prior your package. >=20 > Using "readelf -d libphidget21.so.0.0.0" also presents additional depende= ncies > to: >=20 > - libpthread > - libm > - libdl >=20 > Without considering these dependencies=2C your package may fail at run-ti= me. >=20 > Regards=2C > Juergen >=20 > --=20 > Pengutronix e.K. | Juergen Beisert = | > Linux Solutions for Science and Industry | http://www.pengutronix.de= / | >=20 > --=20 > ptxdist mailing list > ptxdist@pengutronix.de = --_98391b13-7500-44cf-9dc5-18c206bc472e_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Hi Juergen=2C

I'll add the dependencies monday at work!<= /div>
Thanks again for your help on this!

Rega= rds=2C

>=3B From: jbe@p= engutronix.de
>=3B To: ptxdist@pengutronix.de
>=3B Date: Wed=2C 1= 6 May 2012 19:58:09 +0200
>=3B CC: mohtadi_barhoumi@hotmail.fr
>= =3B Subject: Re: [ptxdist] My first Contribution! libpphidget rules :D
&= gt=3B
>=3B Hi Mohtadi=2C
>=3B
>=3B barhoumi mohtadi wrote:=
>=3B >=3B Well=2C libphidget provides a set of "plug and play" buil= ding blocks for low
>=3B >=3B cost USB sensing and control from your= PC. I've needed it to recognize and
>=3B >=3B work with an accelero= mter i'm testing. Just providing it in case someone
>=3B >=3B else n= eed it :D
>=3B >=3B
>=3B >=3B Thanks for your remarks and sug= gestions!
>=3B
>=3B Okay=2C lets start the review process...
= >=3B
>=3B >=3B libphiget.make
>=3B >=3B
>=3B >=3B #= -*-makefile-*-
>=3B >=3B #
>=3B >=3B # Copyright (C) 2012 by= Mohtadi Barhoumi <=3Bmohtadi.barhoumi@univ-reims.fr>=3B
>=3B >= =3B #
>=3B >=3B # See CREDITS for details about who has contributed = to this project.
>=3B >=3B #
>=3B >=3B # For further informat= ion about the PTXdist project and license conditions
>=3B >=3B # see= the README file.
>=3B >=3B #
>=3B >=3B
>=3B >=3B #>=3B >=3B # We provide this package
>=3B >=3B #
>=3B >= =3B PACKAGES-$(PTXCONF_LIBPHIDGET) +=3D libphidget
>=3B >=3B
>= =3B >=3B #
>=3B >=3B # Paths and names
>=3B >=3B #
>= =3B >=3B LIBPHIDGET_VERSION :=3D 2.1.8.20120514
>=3B >=3B LIBPH= IDGET_MD5 :=3D
>=3B
>=3B Please add the MD5 sum here.
= >=3B
>=3B >=3B LIBPHIDGET :=3D libphidget_$(LIBPHIDGET_VER= SION)
>=3B >=3B LIBPHIDGET_SUFFIX :=3D tar.gz
>=3B >=3B LI= BPHIDGET_URL :=3D http://www.phidgets.com/downloads/libraries/$(LIBP= HIDGET).$(LIBPHIDGET_SUFFIX) LIBPHIDGET_SOURCE :=3D $(SRCDIR)/$(LIBPHIDG= ET).
>=3B $(LIBPHIDGET_SUFFIX)
>=3B >=3B LIBPHIDGET_DIR = :=3D $(BUILDDIR)/$(LIBPHIDGET)
>=3B >=3B LIBPHIDGET_LICENSE :=3D = unknown
>=3B
>=3B Please add the license of this package here.>=3B
>=3B >=3B # ----------------------------------------------= ------------------------------
>=3B >=3B # Get
>=3B >=3B # -= ---------------------------------------------------------------------------=
>=3B >=3B
>=3B >=3B #$(LIBPHIDGET_SOURCE):
>=3B >=3B = # @$(call targetinfo)
>=3B >=3B # @$(call get=2C LIBPHIDGET)>=3B
>=3B Its completely commented out. Why not remove it?
>= =3B
>=3B >=3B # ---------------------------------------------------= -------------------------
>=3B >=3B # Prepare
>=3B >=3B # --= --------------------------------------------------------------------------<= br>>=3B >=3B
>=3B >=3B #LIBPHIDGET_CONF_ENV :=3D $(CROSS_ENV)=
>=3B >=3B
>=3B >=3B #
>=3B >=3B # autoconf
>=3B = >=3B #
>=3B >=3B LIBPHIDGET_CONF_TOOL :=3D autoconf
>=3B &= gt=3B #LIBPHIDGET_CONF_OPT :=3D $(CROSS_AUTOCONF_USR)
>=3B >=3B>=3B >=3B #$(STATEDIR)/libphidget.prepare:
>=3B >=3B # @$(c= all targetinfo)
>=3B >=3B # @$(call clean=2C $(LIBPHIDGET_DIR)/co= nfig.cache)
>=3B >=3B # cd $(LIBPHIDGET_DIR) &=3B&=3B \
= >=3B >=3B # $(LIBPHIDGET_PATH) $(LIBPHIDGET_ENV) \
>=3B >= =3B # ./configure $(LIBPHIDGET_CONF_OPT)
>=3B >=3B # @$(ca= ll touch)
>=3B
>=3B Are you really happy with the default config= ure parameters? Maybe there is
>=3B something this package is dependin= g on=2C and if you do not enable or disable
>=3B it here it depends on= the build order if some smart configure scripts guess if
>=3B they sh= ould compile in component X or Y...
>=3B To get a reliable result=2C y= ou should check the external dependencies and add
>=3B them here or in= the corresponding *.in file
>=3B
>=3B A quick look to the outpu= t of "configure --help" shows at least these parameters
>=3B you shoul= d handle with care:
>=3B
>=3B --enable-jni Compile in = Java support
>=3B --enable-debug Turn on debugging
>=3B = --enable-zeroconf Turn on zeroconf=2C choose avahi or bonjour
>=3B= --enable-zeroconf-lookup Turn on zeroconf lookup
>=3B --enable= -labview Turn on Labview support
>=3B --enable-oldlibusb Use l= ibusb-0.1 instead of 1.0
>=3B
>=3B >=3B # --------------------= --------------------------------------------------------
>=3B >=3B #= Compile
>=3B >=3B # ----------------------------------------------= ------------------------------
>=3B >=3B
>=3B >=3B #$(STATEDI= R)/libphidget.compile:
>=3B >=3B # @$(call targetinfo)
>=3B = >=3B # @$(call world/compile=2C LIBPHIDGET)
>=3B >=3B # @$(c= all touch)
>=3B
>=3B Its completely commented out. Why not remov= e it?
>=3B
>=3B >=3B # ---------------------------------------= -------------------------------------
>=3B >=3B # Install
>=3B= >=3B # -----------------------------------------------------------------= -----------
>=3B >=3B
>=3B >=3B #$(STATEDIR)/libphidget.insta= ll:
>=3B >=3B # @$(call targetinfo)
>=3B >=3B # @$(call= world/install=2C LIBPHIDGET)
>=3B >=3B # @$(call touch)
>= =3B
>=3B Same here.
>=3B
>=3B >=3B # -------------------= ---------------------------------------------------------
>=3B >=3B = # Target-Install
>=3B >=3B # --------------------------------------= --------------------------------------
>=3B >=3B
>=3B >=3B $(= STATEDIR)/libphidget.targetinstall:
>=3B >=3B @$(call targetinfo= )
>=3B >=3B
>=3B >=3B @$(call install_init=2C libphidget)=
>=3B >=3B @$(call install_fixup=2C libphidget=2CPRIORITY=2Copti= onal)
>=3B >=3B @$(call install_fixup=2C libphidget=2CSECTION=2C= base)
>=3B >=3B @$(call install_fixup=2C libphidget=2CAUTHOR=2C"= Mohtadi Barhoumi <=3Bmohtadi.barhoumi@univ-reims.fr>=3B")
>=3B >= =3B @$(call install_fixup=2C libphidget=2CDESCRIPTION=2C)
>=3B >= =3B
>=3B >=3B @$(call install_lib=2C libphidget=2C 0=2C 0=2C 064= 4=2C libphidget21)
>=3B >=3B
>=3B >=3B @$(call install_fi= nish=2C libphidget)
>=3B >=3B
>=3B >=3B @$(call touch)>=3B >=3B
>=3B >=3B # -----------------------------------------= -----------------------------------
>=3B >=3B # Clean
>=3B >= =3B # ---------------------------------------------------------------------= -------
>=3B >=3B
>=3B >=3B #$(STATEDIR)/libphidget.clean:>=3B >=3B # @$(call targetinfo)
>=3B >=3B # @$(call clean= _pkg=2C LIBPHIDGET)
>=3B
>=3B Same here.
>=3B
>=3B &g= t=3B # vim: syntax=3Dmake
>=3B >=3B
>=3B >=3B libphidget.in>=3B >=3B
>=3B >=3B ## SECTION=3Dsystem_libraries
>=3B &g= t=3B
>=3B >=3B config LIBPHIDGET
>=3B >=3B tristate
&g= t=3B >=3B prompt "libphidget"
>=3B >=3B help
>=3B >= =3B Phidgets are a set of plug and play building blocks for low
&g= t=3B >=3B cost USB sensing and control from your PC.
>=3B
= >=3B The "--enable-oldlibusb" configure parameter presents at least a dep= endency to
>=3B the LIBUSB. Or the LIBUSB_COMPAT=2C depending on the p= arameter itself.
>=3B
>=3B Without considering this dependency= =2C your package may fail at build-time. You
>=3B must tell PTXdist to= build the libusb/libusbcompat prior your package.
>=3B
>=3B Usi= ng "readelf -d libphidget21.so.0.0.0" also presents additional dependencies=
>=3B to:
>=3B
>=3B - libpthread
>=3B - libm
>= =3B - libdl
>=3B
>=3B Without considering these dependencies=2C= your package may fail at run-time.
>=3B
>=3B Regards=2C
>= =3B Juergen
>=3B
>=3B --
>=3B Pengutronix e.K. = | Juergen Beisert |
>=3B Linux Solutions= for Science and Industry | http://www.pengutronix.de/ |
>=3B >=3B --
>=3B ptxdist mailing list
>=3B ptxdist@pengutronix.d= e
= --_98391b13-7500-44cf-9dc5-18c206bc472e_-- --===============1457644553== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- ptxdist mailing list ptxdist@pengutronix.de --===============1457644553==--