From: Simon Falsig <sfalsig@verity.ch>
To: Michael Olbrich <m.olbrich@pengutronix.de>,
"ptxdist@pengutronix.de" <ptxdist@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] ipkg-push: expose checksum type in platformconfig
Date: Thu, 16 Apr 2020 07:58:43 +0000 [thread overview]
Message-ID: <PR1PR02MB4826E0BC530AA6B060C8AA74BFD80@PR1PR02MB4826.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <20200416064806.GD2081@pengutronix.de>
> > +choice
> > + prompt "checksum type"
> > + default IMAGE_IPKG_CHECKSUM_MD5
> > + help
> > + Sets the checksum type to use when generating the index,
> > + both when pushing to a repository and in PKGDIR.
> > + Note that opkg on the target may need to be specifically
> > + built with support for the selected checksum type.
> > +
> > + config IMAGE_IPKG_CHECKSUM_MD5
> > + bool
> > + prompt "md5"
> > +
> > + config IMAGE_IPKG_CHECKSUM_SHA256
> > + bool
> > + prompt "sha256"
> > +endchoice
>
> Hmmm, we already have the PTXCONF_OPKG_SHA256 option for opkg. Maybe
> just use that one?
Done.
>
> > config IMAGE_XPKG_EXTRA_ARGS
> > string
> > prompt "extra arguments passed to ipkg-build/opkg-build"
> > diff --git a/rules/post/image_ipkg.make b/rules/post/image_ipkg.make
> > index c2171574c..64cdf150f 100644
> > --- a/rules/post/image_ipkg.make
> > +++ b/rules/post/image_ipkg.make
> > @@ -19,13 +19,24 @@ ifdef PTXCONF_IMAGE_IPKG_FORCED_PUSH
> > rm -rf "$(IMAGE_REPO_DIST_DIR)"
> > endif
> > @echo "pushing ipkg packages to ipkg-repository..."
> > - @$(HOST_ENV) $(PTXDIST_TOPDIR)/scripts/ipkg-push \
> > +ifdef PTXCONF_IMAGE_IPKG_CHECKSUM_MD5
> > + @$(HOST_ENV) $(PTXDIST_TOPDIR)/scripts/opkg-push \
> > --ipkgdir $(call remove_quotes,$(PKGDIR)) \
> > --repodir $(call
> remove_quotes,$(PTXCONF_SETUP_IPKG_REPOSITORY)) \
> > --revision $(call remove_quotes,$(PTXDIST_VERSION_FULL)) \
> > --project $(call remove_quotes,$(PTXCONF_PROJECT)) \
> > --dist $(call
> remove_quotes,$(PTXCONF_PROJECT)$(PTXCONF_PROJECT_VERSION)) \
> > - --type opkg
> > + --checksum md5
>
> --checksum $(call
> ptx/ifdef,PTXCONF_IMAGE_IPKG_CHECKSUM_MD5,md5,sha256)
>
Perfect - much cleaner - thanks!
Since the checksum is no longer exposed in the platformconfig, I'm changing the commit title though - will be up in a bit...
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2020-04-16 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 8:41 Simon Falsig
2020-04-15 13:55 ` Simon Falsig
2020-04-15 16:26 ` Simon Falsig
2020-04-16 6:48 ` Michael Olbrich
2020-04-16 7:58 ` Simon Falsig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PR1PR02MB4826E0BC530AA6B060C8AA74BFD80@PR1PR02MB4826.eurprd02.prod.outlook.com \
--to=sfalsig@verity.ch \
--cc=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox