mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Simon Falsig <sfalsig@verity.ch>
To: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>
Subject: [ptxdist] Do ipkg-push with SHA256 checksums
Date: Tue, 7 Apr 2020 10:33:31 +0000	[thread overview]
Message-ID: <PR1PR02MB48263349D108A127B7998C0ABFC30@PR1PR02MB4826.eurprd02.prod.outlook.com> (raw)

Hi,

I'm trying to setup ipkg-push to repository, generating a signed Packages list with SHA256 checksums (using opkg, and the --checksum SHA256 parameter). From what I can see though, the ipkg-push is done by scripts/ipkg-push, which doesn't have a way of setting the checksum type, and just calls ${TYPE}-make-index without any parameters. I can easily hack something together to make this work for me (by just modifying the ipkg-push script), but is there a more correct way?

Judging from the ipkg-push file, it's made to support not just opkg, but also ipkg, which I don't think supports the SHA256 checksum. So just blindly adding the checksum parameter to the commandline would not maintain the generic support. On the other hand, I haven't found any other users of the script than ones where it's called with opkg as the type.

Suggestions:
- Make ipkg-push just support opkg, and allow the checksumtype to be specified as a parameter to the script (image_ipkg.make already generates the local using opkg-make-index only)
- Maintain ipkg/opkg support by making some more elaborate parameters (for instance an "make-index-extra" that is then just passed from ipkg-push to ${TYPE}-make-index
- Pull index generation out of ipkg-push, and let it be done by image_ipkg.make instead (which seems to be the only other place that is currently calling any of the -make-index functions)
- Something entirely different

Any input is welcome! Thanks in advance!
Simon Falsig


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

             reply	other threads:[~2020-04-07 10:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 10:33 Simon Falsig [this message]
2020-04-09  7:55 ` Michael Olbrich
2020-04-15  8:40 ` Simon Falsig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PR1PR02MB48263349D108A127B7998C0ABFC30@PR1PR02MB4826.eurprd02.prod.outlook.com \
    --to=sfalsig@verity.ch \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox