From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.neuhaus.de ([62.109.85.115]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1Yfqz6-0005Dx-HF for ptxdist@pengutronix.de; Wed, 08 Apr 2015 16:29:41 +0200 In-Reply-To: <551D0C71.7040402@pengutronix.de> References: <1427898644-7511-1-git-send-email-oliver.graute@neuhaus.de> <551D0C71.7040402@pengutronix.de> Message-ID: From: Oliver.Graute@neuhaus.de Date: Wed, 8 Apr 2015 16:29:22 +0200 MIME-Version: 1.0 Subject: [ptxdist] Antwort: Re: [PATCHv1 1/1] quagga: this patch adds quagga support to ptxdist Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0533198189==" Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Cc: ptxdist-bounces@pengutronix.de This is an S/MIME signed message --===============0533198189== Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg="sha1"; boundary="----664B30228D4C06F19EB9698D6F765A9C" This is an S/MIME signed message ------664B30228D4C06F19EB9698D6F765A9C MIME-Version: 1.0 Content-type: multipart/alternative; Boundary="0__=4EBBF4B2DFDCB5578f9e8a93df938690918c4EBBF4B2DFDCB557" Content-Disposition: inline --0__=4EBBF4B2DFDCB5578f9e8a93df938690918c4EBBF4B2DFDCB557 Content-type: text/plain; charset=US-ASCII > builds here. > > Please fix: > - remove default CONF_ENV > - remove default stages: compile, install > - the install_alternative for the config files is a good idea, > however /etc/*.sample is probably not used by quagga. > Please provide a set of config files as /etc/* (without .sample) in > this patch. I'm not sure if this a sensible option, beacuse quagga > probsably supports a lot of routing deamon which need different files. > > + @$(call install_copy, quagga, 0, 0, 0644, -, /etc/ripd.conf.sample) > > + @$(call install_copy, quagga, 0, 0, 0644, -, /etc/zebra.conf.sample) should I remove these install copy lines completly? because if i only remove .sample install_copy would fail. Best regards, Oliver --0__=4EBBF4B2DFDCB5578f9e8a93df938690918c4EBBF4B2DFDCB557 Content-type: text/html; charset=US-ASCII Content-Disposition: inline


> builds here.
>
> Please fix:
> - remove default CONF_ENV
> - remove default stages: compile, install
> - the install_alternative for the config files is a good idea,
>   however /etc/*.sample is probably not used by quagga.
>   Please provide a set of config files as /etc/* (without .sample) in
>   this patch. I'm not sure if this a sensible option, beacuse quagga
>   probsably supports a lot of routing deamon which need different files.

> > +   @$(call install_copy, quagga, 0, 0, 0644, -, /etc/ripd.conf.sample)
> > +   @$(call install_copy, quagga, 0, 0, 0644, -, /etc/zebra.conf.sample)

should I remove these install copy lines completly? because if i only remove
.sample install_copy would fail.

Best regards,

Oliver
--0__=4EBBF4B2DFDCB5578f9e8a93df938690918c4EBBF4B2DFDCB557-- ------664B30228D4C06F19EB9698D6F765A9C Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" MIIJigYJKoZIhvcNAQcCoIIJezCCCXcCAQExCzAJBgUrDgMCGgUAMAsGCSqGSIb3 DQEHAaCCB2QwggO7MIICo6ADAgECAhRTTkX+umlHGjEnbVuCyKf7ZDxsAzANBgkq hkiG9w0BAQUFADBlMRgwFgYDVQQDEw9mdzF0Lm5ldWhhdXMuZGUxEDAOBgNVBAsT B0dhdGV3YXkxKjAoBgNVBAoTIURyIE5ldWhhdXMgVGVsZWtvbW11bmlrYXRpb24g R21iSDELMAkGA1UEBhMCZGUwHhcNMDcwMzE5MTYyOTI5WhcNMjcwMzE0MTYyOTI5 WjBlMRgwFgYDVQQDEw9mdzF0Lm5ldWhhdXMuZGUxEDAOBgNVBAsTB0dhdGV3YXkx KjAoBgNVBAoTIURyIE5ldWhhdXMgVGVsZWtvbW11bmlrYXRpb24gR21iSDELMAkG A1UEBhMCZGUwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDO/vqAga4J 46o9WABfVwTFOYiUyA7GMnRK5Nck4InVoQYyBd3kZGANQhSFocmiBd0ptwVaJ5Cd ZivSe1K/FzhNVygo5UyL2C85uqrb51H7pVFV93yuB399V6sMnZnMYkoQpfbGdFfe Qx2YlopLkvvJPQK8I9qbpK/XqjxHcnQh21d4D890UWUAWGIDk4iwwyII75k32HJO 2D+fiygjzfoT0azyEfoYH9jUSA3tk3wQX3N3tCLxsCKta1TIaAyb7eUvXlk3rbrW h5UYVuUMaCo8tEC6mLvoG+gJbAhKePOV4DMMOpplBXCw/bj2CXK7q/3TbJ507jO5 6EBt/q+7+nqpAgMBAAGjYzBhMA8GA1UdEwEB/wQFMAMBAf8wDgYDVR0PAQH/BAQD AgEGMB0GA1UdDgQWBBTs+JXPYwn0sdl6NX256a/JcW9YoDAfBgNVHSMEGDAWgBTs +JXPYwn0sdl6NX256a/JcW9YoDANBgkqhkiG9w0BAQUFAAOCAQEARW5yvbZw9SgS KfhT+ty1dS3DSdMZdEs4BL2q7lGq/kWM5WecF2U4ygvUd/H2Bw4S7n566gTgMxar h0v3cxw36HqDlT1/ZNsPD1653WLDAVNe1/quRrTMRrXwABa/G9W7T4eOBjcjsX/i d5NR3y9UPbbAkozx0TRSO16puxd8tMcAW/p2zzueErvCJU5OwhGvbDgjhp0eXRKk ifkyCeC9ETda8+FaZhKI9Wsq3FW0fONnYhQui4lIHNPbkLJuL3a10pRSgZamkjy/ gTCeiNj2JyrpMD9SrSe/gxguAElQ5Z2xGlpNvfWmJ8HR4vZBvGvfBq/1c5gjsHiC HVq9sHNdajCCA6EwggKJoAMCAQICBFMqmyQwDQYJKoZIhvcNAQEFBQAwZTEYMBYG A1UEAxMPZncxdC5uZXVoYXVzLmRlMRAwDgYDVQQLEwdHYXRld2F5MSowKAYDVQQK EyFEciBOZXVoYXVzIFRlbGVrb21tdW5pa2F0aW9uIEdtYkgxCzAJBgNVBAYTAmRl MB4XDTE0MDMyMDA3MzkxNloXDTM0MDMxNTA3MzkxNlowgYwxCzAJBgNVBAYTAmRl MSowKAYDVQQKEyFEciBOZXVoYXVzIFRlbGVrb21tdW5pa2F0aW9uIEdtYkgxEDAO BgNVBAsTB0dhdGV3YXkxFjAUBgNVBAMTDU9saXZlciBHcmF1dGUxJzAlBgkqhkiG 9w0BCQEWGE9saXZlci5HcmF1dGVAbmV1aGF1cy5kZTCBnzANBgkqhkiG9w0BAQEF AAOBjQAwgYkCgYEA2cA1OPXmWVqiA/k9LmpBl+jwWl5AIxY7hFwKK1fkbw6tNH5u KUp2HKWohFtvYn15hsGCuHBEgnCTr3pkHc3R4mGThYddqsFdTHYIqou5HKZNIZmw iFZGRFRdRVznTrsnjEvT/jIKPj5Tuz5LtX/1uZCoHZaT6J/by0rpwYSl0g8CAwEA AaOBtDCBsTAJBgNVHRMEAjAAMBEGCWCGSAGG+EIBAQQEAwIEsDAsBglghkgBhvhC AQ0EHxYdT3BlblNTTCBHZW5lcmF0ZWQgQ2VydGlmaWNhdGUwHQYDVR0OBBYEFDmu l84LnAlwk+Dm+1kn3o23RSApMB8GA1UdIwQYMBaAFOz4lc9jCfSx2Xo1fbnpr8lx b1igMCMGA1UdEQQcMBqBGE9saXZlci5HcmF1dGVAbmV1aGF1cy5kZTANBgkqhkiG 9w0BAQUFAAOCAQEAczTZdpx+ts4BrR/V74cT3jS9loTnGARQ9w5pMJ7pZ27ecrc4 YAYgCcd9DXfRcoNbX/DZdjsShLArwiQZE3s8lj+hnbXiZwGswFr+gHaLe6GFX0lv EblxGcbJjXQGmQVhqD/ol31gj7geOEoIOn9gHYxuyWmFT8PDxzfSpL9Q5jMLkjHh DI3+orrKQae8kBXYrXbQhiI7c7xbhOl2WgXRkxS0TFOkOAWAVB0u0NtoxXMDPHPW eedw3q5/5h3gHxHPoffGfgSXlNiTI8Jj9LQ3RMF4VWKHynOHuDzxip9kxD2awhJI IISXkGksMdvABoFXlweOSu9tc7tGc7nq2Zn3BzGCAe4wggHqAgEBMG0wZTEYMBYG A1UEAxMPZncxdC5uZXVoYXVzLmRlMRAwDgYDVQQLEwdHYXRld2F5MSowKAYDVQQK EyFEciBOZXVoYXVzIFRlbGVrb21tdW5pa2F0aW9uIEdtYkgxCzAJBgNVBAYTAmRl AgRTKpskMAkGBSsOAwIaBQCggdgwGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAc BgkqhkiG9w0BCQUxDxcNMTUwNDA4MTQyOTQwWjAjBgkqhkiG9w0BCQQxFgQU/i+O HriegzOq5XnmqyOLvWOpqSgweQYJKoZIhvcNAQkPMWwwajALBglghkgBZQMEASow CwYJYIZIAWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzAOBggqhkiG9w0D AgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgwDQYJ KoZIhvcNAQEBBQAEgYBqqIFZtHhGNQ60vIy1p6wX0wue/pSQ4hVoZRk0dUFFzNzU QIek1YOvCCbttVyUP6nFHlwXjwlxhvAJkWtd3iEwVFqNLY7E3/KqXlksAjLy5JQM xTxPqoABDP76bBzvk5XKw9pRnhxFqeEnu8IUfbqZaZwAtga7A5llcAKgurFZ3A== ------664B30228D4C06F19EB9698D6F765A9C-- --===============0533198189== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- ptxdist mailing list ptxdist@pengutronix.de --===============0533198189==--