[ptxdist] Antwort: Re: [PATCHv4 1/1] linux-pam: this patch add Linux-PAM support to ptxdist

[Oliver.Graute@neuhaus.de]

[-- Attachment #1.1.1: Type: text/plain, Size: 1103 bytes --]



> > diff --git a/rules/linux-pam.in b/rules/linux-pam.in
> > new file mode 100644
> > index 0000000..d76e4db
> > --- /dev/null
> > +++ b/rules/linux-pam.in
> > @@ -0,0 +1,13 @@
> > +## SECTION=networking
> > +
> > +config LINUX_PAM
> > +   tristate
> > +   prompt "linux-pam"
>
> I think a dependency to flex is missing, maybe it's only needed when
> compiling with selinux support...:

flex support is necessary. i will add it with a select FLEX statement

> libtool: link: arm-cortexa8-linux-gnueabihf-gcc -g -O2 -Wl,--as-needed
> -Wl,--no-undefined -Wl,-O1 -o pam_conv1 pam_conv_l.o pam_conv_y.o
> pam_conv_l.o: In function `yylex':
>
platform-1234/build-target/Linux-PAM-1.1.8/conf/pam_conv1/pam_conv_l.c:871:
> undefined reference to `yywrap'

flex dependency will fix that error

> > +#
> > +# autoconf
> > +#
> > +LINUX_PAM_CONF_TOOL   := autoconf
>
> There a lot of options to pam's ./configure, please provide sensible
> defaults via CONF_OPT (at least for external packages) and make use of
> the gobal ptxdist option:
>

hm i don't know which ones are necessary here.

Best regards,

Oliver

[-- Attachment #1.1.2: Type: text/html, Size: 1520 bytes --]

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 2446 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de