Re: [ptxdist] Using PTXdist on Mac OS

[Daniel Kriesten <daniel.kriesten@etit.tu-chemnitz.de>]

[-- Attachment #1.1: Type: text/plain, Size: 3752 bytes --]


Am 10.12.2012 um 09:46 schrieb Michael Olbrich:

> On Sat, Dec 08, 2012 at 04:31:34PM +0100, Daniel Kriesten wrote:
>> 
>> 
>> this is quite a late reply to this mail. But today I struggled about this once again. So here its the patch.
> 
> ${PTXDIST_TOPDIR}/bin/xargs should be a gnu xargs. Is that not used?

It  is used, if it already exists. But on a system, where gnu xargs is not the default (like Mac), something like
./configure
make clean

or
./configure
make
make clean; make clean

fails, due to missing xargs with GNUoption -r

Regards
	Daniel

> Michael
> 
>> ---8<---
>> 
>> From dd717be19e704b71a030b091d2604d7a05ccebb2 Mon Sep 17 00:00:00 2001
>> From: Daniel Kriesten <krid@tu-chemnitz.eu>
>> Date: Sat, 8 Dec 2012 16:27:35 +0100
>> Subject: [PATCH] Remove -r from call to xargs
>> 
>> The '-r' flag is a GNU extension. To enhance compatibility remove '-r'
>> and suppress error mesages using 'rm -f'.
>> ---
>> Makefile.in | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Makefile.in b/Makefile.in
>> index e171045..72509a2 100644
>> --- a/Makefile.in
>> +++ b/Makefile.in
>> @@ -71,7 +71,7 @@ environment:
>> 
>> clean:
>>        @rm -f .done
>> -       @find "$(abs_srcdir)/bin" -type l -print0 | xargs -r -0 rm
>> +       @find "$(abs_srcdir)/bin" -type l -print0 | xargs -0 rm -f
>>        @$(MAKE) -C "$(abs_srcdir)/scripts/kconfig" clean
>> 
>> dirty-check:
>> -- 
>> 1.8.0
>> 
>> --->8---
>> 
>> Am 19.04.2012 um 14:25 schrieb Andreas Bießmann:
>>> Hi,
>>> 
>>> On 19.04.2012 14:04, Daniel Kriesten wrote:
>>>> Hi all,
>>>> 
>>>> Am 19.04.2012 um 13:29 schrieb Andreas Bießmann:
>>>> 
>>>>> Hi all,
>>>>> 
>>>>> On 19.04.2012 12:41, Daniel Kriesten wrote:
>>>>>> Hi Michael,
>>>>>> at leas on a Mac (OS X 10.6.8) the BSD find supports -print0
>>>>> 
>>>>> yes, OS X delivered BSD find supports -print0, but it does _not_ support
>>>>> omitting the path!
>>>>> [...]
>>>>> OR leaving the xargs -r param
>>>>> 
>>>>> ---8<---
>>>>> --- a/Makefile.in
>>>>> +++ b/Makefile.in
>>>>> @@ -63,7 +63,7 @@ environment:
>>>>> 
>>>>> clean:
>>>>> 	@rm -f .done
>>>>> -	@find "$(abs_srcdir)/bin" -type l -print0 | xargs -r -0 rm
>>>>> +	@find "$(abs_srcdir)/bin" -type l -print0 | xargs -0 rm
>>>>> 	@$(MAKE) -C "$(abs_srcdir)/scripts/kconfig" clean
>>>>> --->8---
>>>> 
>>>> This one is my promoted solution in yesterdays patch, except I would recommend 'rm -f' to avoid errors if find returns an empty list.
>>> 
>>> well ok, +1 for your solution. I maybe missed that in my mail history
>>> (can you please send patches inline next time?).
>>> 
>>> best regards
>>> 
>>> Andreas Bießmann
>>> 
>>> -- 
>>> ptxdist mailing list
>>> ptxdist@pengutronix.de
>>> 
>> 
>> 
>> -- 
>> Daniel Kriesten
>> Professur Schaltkreis- und Systementwurf
>> Technische Universität Chemnitz, Reichenhainer Str. 31-33, 09126 Chemnitz
>> Tel: +49 371 531 33058  Fax: +49 371 531 833058
>> http://www.tu-chemnitz.de/etit/sse
>> 
> 
> 
> 
>> -- 
>> ptxdist mailing list
>> ptxdist@pengutronix.de
> 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 


-- 
Daniel Kriesten
Professur Schaltkreis- und Systementwurf
Technische Universität Chemnitz, Reichenhainer Str. 31-33, 09126 Chemnitz
Tel: +49 371 531 33058  Fax: +49 371 531 833058
http://www.tu-chemnitz.de/etit/sse


[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4964 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de