From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
In-Reply-To: <20210114225049.1634-1-rhi@pengutronix.de>
MIME-Version: 1.0
Message-Id: <E1l0N7d-00CDKl-GU@dude03.red.stw.pengutronix.de>
From: Michael Olbrich <mol@pengutronix.de>
Date: Fri, 15 Jan 2021 12:18:29 +0100
Subject: Re: [ptxdist] [APPLIED] ptxd_make_image_common: optionally install
 debug packages into rootfs
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>

Thanks, applied as cbba868c31f8be9ed521b19ea0e3095c13a19a17.

Michael

[sent from post-receive hook]

On Fri, 15 Jan 2021 12:18:29 +0100, Roland Hieber <rhi@pengutronix.de> wrote:
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20210114225049.1634-1-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/00debug-packages.in b/rules/00debug-packages.in
> index 64dd254f15e9..1e3ea0f4837b 100644
> --- a/rules/00debug-packages.in
> +++ b/rules/00debug-packages.in
> @@ -10,3 +10,15 @@ config DEBUG_PACKAGES
>  	  are otherwise only available in nfsroot.
>  	  This is useful to run debug tools such as gdb, valgrind, perf
>  	  etc. on a normal (not nfsroot) rootfs.
> +
> +config DEBUG_PACKAGES_INSTALL
> +	bool
> +	select DEBUG_PACKAGES
> +	prompt "install debug packages into rootfs"
> +	help
> +	  Include debug symbols of all packages that are installed into the root
> +	  filesystem. This is needed if you want to run gdb, valgrind, etc. on
> +	  the target.
> +
> +	  Debug symbols can take a certain amount of disk space, make sure your
> +	  root file system is big enough.
> diff --git a/scripts/lib/ptxd_make_image_common.sh b/scripts/lib/ptxd_make_image_common.sh
> index 1170226aed70..551420080669 100644
> --- a/scripts/lib/ptxd_make_image_common.sh
> +++ b/scripts/lib/ptxd_make_image_common.sh
> @@ -48,6 +48,15 @@ Run first 'ptxdist clean root' then 'ptxdist images' again.
>  "
>  	fi
>  
> +	if ptxd_get_ptxconf PTXCONF_DEBUG_PACKAGES_INSTALL > /dev/null; then
> +	    # some packages don't install binaries, so they don't have dbgsyms.
> +	    # don't complain about that.
> +	    ipkg_files="${image_ipkg_repo_dirs[@]/%//${1}-dbgsym_*.ipk}"
> +	    if ptxd_get_path ${ipkg_files[*]}; then
> +		ptxd_reply_ipkg_files[${#ptxd_reply_ipkg_files[@]}]="${ptxd_reply}"
> +	    fi
> +	fi
> +
>  	shift
>      done
>  }

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de