* [ptxdist] [PATCH v3] rootfs: Fix creation of the /media directory
@ 2020-10-08 7:32 Gavin Schenk
2020-10-08 7:49 ` Uwe Kleine-König
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gavin Schenk @ 2020-10-08 7:32 UTC (permalink / raw)
To: ptxdist; +Cc: Gavin Schenk
Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
On our read-only system we mount a tmpfs on directory '/media' in order
to dynamically create additional mount points there.
Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
---
Hi,
the "messed whitespaces" of changes in our mail server software.
Our IT department implemented a workaround, I hope this
mail looks better.
Regards
Gavin
rules/rootfs.make | 1 +
1 file changed, 1 insertion(+)
diff --git a/rules/rootfs.make b/rules/rootfs.make
index 6b37db5bd..419ca001e 100644
--- a/rules/rootfs.make
+++ b/rules/rootfs.make
@@ -63,6 +63,7 @@ ifdef PTXCONF_ROOTFS_HOME_ROOT
@$(call install_copy, rootfs, 0, 0, 0700, /root)
endif
ifdef PTXCONF_ROOTFS_MEDIA
+ @$(call install_copy, rootfs, 0, 0, 0755, /media)
ifneq ($(call remove_quotes,$(PTXCONF_ROOTFS_MEDIA1)),)
@$(call install_copy, rootfs, 0, 0, 0777, /media/$(PTXCONF_ROOTFS_MEDIA1))
endif
--
2.28.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [ptxdist] [PATCH v3] rootfs: Fix creation of the /media directory
2020-10-08 7:32 [ptxdist] [PATCH v3] rootfs: Fix creation of the /media directory Gavin Schenk
@ 2020-10-08 7:49 ` Uwe Kleine-König
2020-10-09 12:18 ` Michael Olbrich
2020-10-14 10:30 ` [ptxdist] [APPLIED] " Michael Olbrich
2 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2020-10-08 7:49 UTC (permalink / raw)
To: Gavin Schenk; +Cc: ptxdist
[-- Attachment #1.1: Type: text/plain, Size: 971 bytes --]
On Thu, Oct 08, 2020 at 09:32:53AM +0200, Gavin Schenk wrote:
> Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
> even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
>
> On our read-only system we mount a tmpfs on directory '/media' in order
> to dynamically create additional mount points there.
>
> Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
> Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
> ---
> Hi,
>
> the "messed whitespaces" of changes in our mail server software.
> Our IT department implemented a workaround, I hope this
> mail looks better.
It seems the workaround worked fine. I didn't try to apply, but at least
now there are tabs in your patch.
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 181 bytes --]
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH v3] rootfs: Fix creation of the /media directory
2020-10-08 7:32 [ptxdist] [PATCH v3] rootfs: Fix creation of the /media directory Gavin Schenk
2020-10-08 7:49 ` Uwe Kleine-König
@ 2020-10-09 12:18 ` Michael Olbrich
2020-10-14 10:30 ` [ptxdist] [APPLIED] " Michael Olbrich
2 siblings, 0 replies; 4+ messages in thread
From: Michael Olbrich @ 2020-10-09 12:18 UTC (permalink / raw)
To: ptxdist
On Thu, Oct 08, 2020 at 09:32:53AM +0200, Gavin Schenk wrote:
> Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
> even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
>
> On our read-only system we mount a tmpfs on directory '/media' in order
> to dynamically create additional mount points there.
>
> Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
> Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
> ---
> Hi,
>
> the "messed whitespaces" of changes in our mail server software.
> Our IT department implemented a workaround, I hope this
> mail looks better.
Looks good now.
Michael
> Regards
> Gavin
>
>
> rules/rootfs.make | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/rules/rootfs.make b/rules/rootfs.make
> index 6b37db5bd..419ca001e 100644
> --- a/rules/rootfs.make
> +++ b/rules/rootfs.make
> @@ -63,6 +63,7 @@ ifdef PTXCONF_ROOTFS_HOME_ROOT
> @$(call install_copy, rootfs, 0, 0, 0700, /root)
> endif
> ifdef PTXCONF_ROOTFS_MEDIA
> + @$(call install_copy, rootfs, 0, 0, 0755, /media)
> ifneq ($(call remove_quotes,$(PTXCONF_ROOTFS_MEDIA1)),)
> @$(call install_copy, rootfs, 0, 0, 0777, /media/$(PTXCONF_ROOTFS_MEDIA1))
> endif
> --
> 2.28.0
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [APPLIED] rootfs: Fix creation of the /media directory
2020-10-08 7:32 [ptxdist] [PATCH v3] rootfs: Fix creation of the /media directory Gavin Schenk
2020-10-08 7:49 ` Uwe Kleine-König
2020-10-09 12:18 ` Michael Olbrich
@ 2020-10-14 10:30 ` Michael Olbrich
2 siblings, 0 replies; 4+ messages in thread
From: Michael Olbrich @ 2020-10-14 10:30 UTC (permalink / raw)
To: ptxdist; +Cc: Gavin Schenk
Thanks, applied as 70ddbd1504778cbf9b5980765cb5f11bbf2f3eb2.
Michael
[sent from post-receive hook]
On Wed, 14 Oct 2020 12:30:50 +0200, Gavin Schenk <g.schenk@eckelmann.de> wrote:
> Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
> even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
>
> On our read-only system we mount a tmpfs on directory '/media' in order
> to dynamically create additional mount points there.
>
> Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
> Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
> Message-Id: <20201008073253.20055-1-g.schenk@eckelmann.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/rootfs.make b/rules/rootfs.make
> index 6b37db5bdd52..419ca001e4ac 100644
> --- a/rules/rootfs.make
> +++ b/rules/rootfs.make
> @@ -63,6 +63,7 @@ ifdef PTXCONF_ROOTFS_HOME_ROOT
> @$(call install_copy, rootfs, 0, 0, 0700, /root)
> endif
> ifdef PTXCONF_ROOTFS_MEDIA
> + @$(call install_copy, rootfs, 0, 0, 0755, /media)
> ifneq ($(call remove_quotes,$(PTXCONF_ROOTFS_MEDIA1)),)
> @$(call install_copy, rootfs, 0, 0, 0777, /media/$(PTXCONF_ROOTFS_MEDIA1))
> endif
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-14 10:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 7:32 [ptxdist] [PATCH v3] rootfs: Fix creation of the /media directory Gavin Schenk
2020-10-08 7:49 ` Uwe Kleine-König
2020-10-09 12:18 ` Michael Olbrich
2020-10-14 10:30 ` [ptxdist] [APPLIED] " Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox