From: Michael Olbrich <mol@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] mxt-app: fix compilation with gcc10
Date: Wed, 14 Oct 2020 12:30:45 +0200 [thread overview]
Message-ID: <E1kSe3R-0003TZ-HM@dude02.hi.pengutronix.de> (raw)
In-Reply-To: <20200928161032.13579-2-l.stach@pengutronix.de>
Thanks, applied as e79956d2b909bd40fdc5e1cfad2086e70728030e.
Michael
[sent from post-receive hook]
On Wed, 14 Oct 2020 12:30:45 +0200, Lucas Stach <l.stach@pengutronix.de> wrote:
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Message-Id: <20200928161032.13579-2-l.stach@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/patches/mxt-app-1.28/0001-Make-mxt_sigint_rx-extern-in-header-file.patch b/patches/mxt-app-1.28/0001-Make-mxt_sigint_rx-extern-in-header-file.patch
> new file mode 100644
> index 000000000000..a14f9df4fc0f
> --- /dev/null
> +++ b/patches/mxt-app-1.28/0001-Make-mxt_sigint_rx-extern-in-header-file.patch
> @@ -0,0 +1,29 @@
> +From: Khem Raj <raj.khem@gmail.com>
> +Date: Tue, 11 Aug 2020 18:21:47 -0700
> +Subject: [PATCH] Make mxt_sigint_rx extern in header file
> +
> +Its defined in src/mxt-app/signal.c like
> +
> +volatile sig_atomic_t mxt_sigint_rx = 0;
> +
> +Therefore we do not need another definition in header file, this fixes
> +the build with -fno-common ( which is default with gcc 10+)
> +
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +---
> + src/mxt-app/mxt_app.h | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/src/mxt-app/mxt_app.h b/src/mxt-app/mxt_app.h
> +index daa1519ce10d..a326a9d49b50 100644
> +--- a/src/mxt-app/mxt_app.h
> ++++ b/src/mxt-app/mxt_app.h
> +@@ -103,7 +103,7 @@ typedef enum mxt_app_cmd_t {
> +
> + //******************************************************************************
> + /// \brief Signal handler semaphore
> +-volatile sig_atomic_t mxt_sigint_rx;
> ++extern volatile sig_atomic_t mxt_sigint_rx;
> +
> + struct t37_diagnostic_data;
> + struct mxt_conn_info;
> diff --git a/patches/mxt-app-1.28/series b/patches/mxt-app-1.28/series
> new file mode 100644
> index 000000000000..133b77ee1312
> --- /dev/null
> +++ b/patches/mxt-app-1.28/series
> @@ -0,0 +1,4 @@
> +# generated by git-ptx-patches
> +#tag:base --start-number 1
> +0001-Make-mxt_sigint_rx-extern-in-header-file.patch
> +# 6096d6b079bf36345ab6e22b1ec90c28 - git-ptx-patches magic
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2020-10-14 10:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 16:10 [ptxdist] [PATCH 1/2] usbip: version bump 5.6 -> 5.8 Lucas Stach
2020-09-28 16:10 ` [ptxdist] [PATCH 2/2] mxt-app: fix compilation with gcc10 Lucas Stach
2020-10-14 10:30 ` Michael Olbrich [this message]
2020-10-14 10:30 ` [ptxdist] [APPLIED] usbip: version bump 5.6 -> 5.8 Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1kSe3R-0003TZ-HM@dude02.hi.pengutronix.de \
--to=mol@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox