From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
In-Reply-To: <20200806164947.4187-1-rhi@pengutronix.de>
MIME-Version: 1.0
Message-Id: <E1k7YTN-0008BU-Oj@dude02.hi.pengutronix.de>
From: Michael Olbrich <mol@pengutronix.de>
Date: Mon, 17 Aug 2020 08:18:21 +0200
Subject: Re: [ptxdist] [APPLIED] kernel: fix typo in HOSTCXX variable
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>

Thanks, applied as 80ce928da2c8e0822e91964f0d65afcea5966c1c.

Michael

[sent from post-receive hook]

On Mon, 17 Aug 2020 08:18:21 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> The typo makes the variable expand to nothing. This was probably never
> caught because g++ is usually not used when building the kernel.
> 
> Fixes: a668fd6120742fe5ef6e (2020-06-11, "kernel: handle plugin detection for kernel version >= v5.7")
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20200806164947.4187-1-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/kernel.make b/rules/kernel.make
> index 0d90784e6ff7..c91267c34da0 100644
> --- a/rules/kernel.make
> +++ b/rules/kernel.make
> @@ -77,7 +77,7 @@ KERNEL_SHARED_OPT := \
>  ifndef PTXCONF_KERNEL_GCC_PLUGINS
>  # no gcc plugins; avoid config changes depending on the host compiler
>  KERNEL_SHARED_OPT += \
> -	HOSTCXX="$(HOSTXX) -DGENERATOR_FILE" \
> +	HOSTCXX="$(HOSTCXX) -DGENERATOR_FILE" \
>  	HOSTCC="$(HOSTCC) -DGENERATOR_FILE"
>  endif
>  
> diff --git a/rules/templates/template-kernel-make b/rules/templates/template-kernel-make
> index 5274b42c2362..c53110165ec3 100644
> --- a/rules/templates/template-kernel-make
> +++ b/rules/templates/template-kernel-make
> @@ -43,7 +43,7 @@ KERNEL_@PACKAGE@_SHARED_OPT	:= \
>  
>  # no gcc plugins; avoid config changes depending on the host compiler
>  KERNEL_@PACKAGE@_SHARED_OPT	+= \
> -	HOSTCXX="$(HOSTXX) -DGENERATOR_FILE" \
> +	HOSTCXX="$(HOSTCXX) -DGENERATOR_FILE" \
>  	HOSTCC="$(HOSTCC) -DGENERATOR_FILE"
>  
>  KERNEL_@PACKAGE@_CONF_OPT	:= \

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de