mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] kernel: fix typo in HOSTCXX variable
@ 2020-08-06 16:49 Roland Hieber
  2020-08-17  6:18 ` [ptxdist] [APPLIED] " Michael Olbrich
  0 siblings, 1 reply; 2+ messages in thread
From: Roland Hieber @ 2020-08-06 16:49 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

The typo makes the variable expand to nothing. This was probably never
caught because g++ is usually not used when building the kernel.

Fixes: a668fd6120742fe5ef6e (2020-06-11, "kernel: handle plugin detection for kernel version >= v5.7")
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/kernel.make                    | 2 +-
 rules/templates/template-kernel-make | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/rules/kernel.make b/rules/kernel.make
index 78ad72c3cf97..7032b0caaba0 100644
--- a/rules/kernel.make
+++ b/rules/kernel.make
@@ -75,7 +75,7 @@ KERNEL_SHARED_OPT := \
 ifndef PTXCONF_KERNEL_GCC_PLUGINS
 # no gcc plugins; avoid config changes depending on the host compiler
 KERNEL_SHARED_OPT += \
-	HOSTCXX="$(HOSTXX) -DGENERATOR_FILE" \
+	HOSTCXX="$(HOSTCXX) -DGENERATOR_FILE" \
 	HOSTCC="$(HOSTCC) -DGENERATOR_FILE"
 endif
 
diff --git a/rules/templates/template-kernel-make b/rules/templates/template-kernel-make
index 5274b42c2362..c53110165ec3 100644
--- a/rules/templates/template-kernel-make
+++ b/rules/templates/template-kernel-make
@@ -43,7 +43,7 @@ KERNEL_@PACKAGE@_SHARED_OPT	:= \
 
 # no gcc plugins; avoid config changes depending on the host compiler
 KERNEL_@PACKAGE@_SHARED_OPT	+= \
-	HOSTCXX="$(HOSTXX) -DGENERATOR_FILE" \
+	HOSTCXX="$(HOSTCXX) -DGENERATOR_FILE" \
 	HOSTCC="$(HOSTCC) -DGENERATOR_FILE"
 
 KERNEL_@PACKAGE@_CONF_OPT	:= \
-- 
2.28.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [ptxdist] [APPLIED] kernel: fix typo in HOSTCXX variable
  2020-08-06 16:49 [ptxdist] [PATCH] kernel: fix typo in HOSTCXX variable Roland Hieber
@ 2020-08-17  6:18 ` Michael Olbrich
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2020-08-17  6:18 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

Thanks, applied as 80ce928da2c8e0822e91964f0d65afcea5966c1c.

Michael

[sent from post-receive hook]

On Mon, 17 Aug 2020 08:18:21 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> The typo makes the variable expand to nothing. This was probably never
> caught because g++ is usually not used when building the kernel.
> 
> Fixes: a668fd6120742fe5ef6e (2020-06-11, "kernel: handle plugin detection for kernel version >= v5.7")
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20200806164947.4187-1-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/kernel.make b/rules/kernel.make
> index 0d90784e6ff7..c91267c34da0 100644
> --- a/rules/kernel.make
> +++ b/rules/kernel.make
> @@ -77,7 +77,7 @@ KERNEL_SHARED_OPT := \
>  ifndef PTXCONF_KERNEL_GCC_PLUGINS
>  # no gcc plugins; avoid config changes depending on the host compiler
>  KERNEL_SHARED_OPT += \
> -	HOSTCXX="$(HOSTXX) -DGENERATOR_FILE" \
> +	HOSTCXX="$(HOSTCXX) -DGENERATOR_FILE" \
>  	HOSTCC="$(HOSTCC) -DGENERATOR_FILE"
>  endif
>  
> diff --git a/rules/templates/template-kernel-make b/rules/templates/template-kernel-make
> index 5274b42c2362..c53110165ec3 100644
> --- a/rules/templates/template-kernel-make
> +++ b/rules/templates/template-kernel-make
> @@ -43,7 +43,7 @@ KERNEL_@PACKAGE@_SHARED_OPT	:= \
>  
>  # no gcc plugins; avoid config changes depending on the host compiler
>  KERNEL_@PACKAGE@_SHARED_OPT	+= \
> -	HOSTCXX="$(HOSTXX) -DGENERATOR_FILE" \
> +	HOSTCXX="$(HOSTCXX) -DGENERATOR_FILE" \
>  	HOSTCC="$(HOSTCC) -DGENERATOR_FILE"
>  
>  KERNEL_@PACKAGE@_CONF_OPT	:= \

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-17  6:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 16:49 [ptxdist] [PATCH] kernel: fix typo in HOSTCXX variable Roland Hieber
2020-08-17  6:18 ` [ptxdist] [APPLIED] " Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox