mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <mol@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] kernel: fix typo in HOSTCXX variable
Date: Mon, 17 Aug 2020 08:18:21 +0200	[thread overview]
Message-ID: <E1k7YTN-0008BU-Oj@dude02.hi.pengutronix.de> (raw)
In-Reply-To: <20200806164947.4187-1-rhi@pengutronix.de>

Thanks, applied as 80ce928da2c8e0822e91964f0d65afcea5966c1c.

Michael

[sent from post-receive hook]

On Mon, 17 Aug 2020 08:18:21 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> The typo makes the variable expand to nothing. This was probably never
> caught because g++ is usually not used when building the kernel.
> 
> Fixes: a668fd6120742fe5ef6e (2020-06-11, "kernel: handle plugin detection for kernel version >= v5.7")
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20200806164947.4187-1-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/kernel.make b/rules/kernel.make
> index 0d90784e6ff7..c91267c34da0 100644
> --- a/rules/kernel.make
> +++ b/rules/kernel.make
> @@ -77,7 +77,7 @@ KERNEL_SHARED_OPT := \
>  ifndef PTXCONF_KERNEL_GCC_PLUGINS
>  # no gcc plugins; avoid config changes depending on the host compiler
>  KERNEL_SHARED_OPT += \
> -	HOSTCXX="$(HOSTXX) -DGENERATOR_FILE" \
> +	HOSTCXX="$(HOSTCXX) -DGENERATOR_FILE" \
>  	HOSTCC="$(HOSTCC) -DGENERATOR_FILE"
>  endif
>  
> diff --git a/rules/templates/template-kernel-make b/rules/templates/template-kernel-make
> index 5274b42c2362..c53110165ec3 100644
> --- a/rules/templates/template-kernel-make
> +++ b/rules/templates/template-kernel-make
> @@ -43,7 +43,7 @@ KERNEL_@PACKAGE@_SHARED_OPT	:= \
>  
>  # no gcc plugins; avoid config changes depending on the host compiler
>  KERNEL_@PACKAGE@_SHARED_OPT	+= \
> -	HOSTCXX="$(HOSTXX) -DGENERATOR_FILE" \
> +	HOSTCXX="$(HOSTCXX) -DGENERATOR_FILE" \
>  	HOSTCC="$(HOSTCC) -DGENERATOR_FILE"
>  
>  KERNEL_@PACKAGE@_CONF_OPT	:= \

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

      reply	other threads:[~2020-08-17  6:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06 16:49 [ptxdist] [PATCH] " Roland Hieber
2020-08-17  6:18 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1k7YTN-0008BU-Oj@dude02.hi.pengutronix.de \
    --to=mol@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox