From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
In-Reply-To: <20200724155103.6374-3-bruno.thomsen@gmail.com>
MIME-Version: 1.0
Message-Id: <E1k2Tyy-00029W-4i@dude02.hi.pengutronix.de>
From: Michael Olbrich <mol@pengutronix.de>
Date: Mon, 03 Aug 2020 08:30:00 +0200
Subject: Re: [ptxdist] [APPLIED] image-root-squashfs: add zstd compression
 option
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>

Thanks, applied as 32df99ca6d0b839a825c15319af4c010f93f265d.

Michael

[sent from post-receive hook]

On Mon, 03 Aug 2020 08:30:00 +0200, Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
> Set block size and compression level parameters for optimal
> result by default.
> 
> BLOCK_SIZE="1M"
> EXTRA_ARGS="-Xcompression-level 22"
> 
> It's still very	fast on	an ordinary laptop.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> Message-Id: <20200724155103.6374-3-bruno.thomsen@gmail.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/platforms/image-root-squashfs.in b/platforms/image-root-squashfs.in
> index 5f9368770ad0..98aae9c1c089 100644
> --- a/platforms/image-root-squashfs.in
> +++ b/platforms/image-root-squashfs.in
> @@ -4,6 +4,7 @@ menuconfig IMAGE_ROOT_SQUASHFS
>  	tristate
>  	select HOST_GENIMAGE
>  	select HOST_SQUASHFS_TOOLS
> +	select HOST_SQUASHFS_TOOLS_ZSTD_SUPPORT	if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
>  	select IMAGE_ROOT_TGZ
>  	prompt "Generate images/root.squashfs "
>  	help
> @@ -45,6 +46,11 @@ choice
>  	help
>  	  Select your preferred compression mode.
>  
> +	config IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
> +	bool "zstd"
> +	help
> +	  Select your preferred compression mode.
> +
>  endchoice
>  
>  config IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE
> @@ -54,10 +60,12 @@ config IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE
>          default "lzo" if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_LZO
>          default "lz4" if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_LZ4
>          default "xz" if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_XZ
> +        default "zstd" if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
>  
>  config IMAGE_ROOT_SQUASHFS_BLOCK_SIZE
>  	string
> -	default "128k"
> +	default "128k" if !IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
> +	default "1M" if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
>  	prompt "Block size"
>  	help
>  	  This allows the compression data block size to be selected, both "K" and "M"
> @@ -65,6 +73,8 @@ config IMAGE_ROOT_SQUASHFS_BLOCK_SIZE
>  
>  config IMAGE_ROOT_SQUASHFS_EXTRA_ARGS
>  	string
> +	default "" if !IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
> +	default "-Xcompression-level 22" if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
>  	prompt "extra arguments passed to mksquashfs"
>  	help
>  	  You can add extra arguments for mksquashfs here

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de