mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <mol@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>
Subject: Re: [ptxdist] [APPLIED] image-root-squashfs: add zstd compression option
Date: Mon, 03 Aug 2020 08:30:00 +0200	[thread overview]
Message-ID: <E1k2Tyy-00029W-4i@dude02.hi.pengutronix.de> (raw)
In-Reply-To: <20200724155103.6374-3-bruno.thomsen@gmail.com>

Thanks, applied as 32df99ca6d0b839a825c15319af4c010f93f265d.

Michael

[sent from post-receive hook]

On Mon, 03 Aug 2020 08:30:00 +0200, Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
> Set block size and compression level parameters for optimal
> result by default.
> 
> BLOCK_SIZE="1M"
> EXTRA_ARGS="-Xcompression-level 22"
> 
> It's still very	fast on	an ordinary laptop.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> Message-Id: <20200724155103.6374-3-bruno.thomsen@gmail.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/platforms/image-root-squashfs.in b/platforms/image-root-squashfs.in
> index 5f9368770ad0..98aae9c1c089 100644
> --- a/platforms/image-root-squashfs.in
> +++ b/platforms/image-root-squashfs.in
> @@ -4,6 +4,7 @@ menuconfig IMAGE_ROOT_SQUASHFS
>  	tristate
>  	select HOST_GENIMAGE
>  	select HOST_SQUASHFS_TOOLS
> +	select HOST_SQUASHFS_TOOLS_ZSTD_SUPPORT	if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
>  	select IMAGE_ROOT_TGZ
>  	prompt "Generate images/root.squashfs "
>  	help
> @@ -45,6 +46,11 @@ choice
>  	help
>  	  Select your preferred compression mode.
>  
> +	config IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
> +	bool "zstd"
> +	help
> +	  Select your preferred compression mode.
> +
>  endchoice
>  
>  config IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE
> @@ -54,10 +60,12 @@ config IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE
>          default "lzo" if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_LZO
>          default "lz4" if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_LZ4
>          default "xz" if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_XZ
> +        default "zstd" if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
>  
>  config IMAGE_ROOT_SQUASHFS_BLOCK_SIZE
>  	string
> -	default "128k"
> +	default "128k" if !IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
> +	default "1M" if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
>  	prompt "Block size"
>  	help
>  	  This allows the compression data block size to be selected, both "K" and "M"
> @@ -65,6 +73,8 @@ config IMAGE_ROOT_SQUASHFS_BLOCK_SIZE
>  
>  config IMAGE_ROOT_SQUASHFS_EXTRA_ARGS
>  	string
> +	default "" if !IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
> +	default "-Xcompression-level 22" if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
>  	prompt "extra arguments passed to mksquashfs"
>  	help
>  	  You can add extra arguments for mksquashfs here

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2020-08-03  6:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 15:50 [ptxdist] [PATCH v3 1/5] host-zstd: new package Bruno Thomsen
2020-07-24 15:51 ` [ptxdist] [PATCH v3 2/5] host-squashfs-tools: add support for zstd contitional Bruno Thomsen
2020-08-03  6:29   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-07-24 15:51 ` [ptxdist] [PATCH v3 3/5] image-root-squashfs: add zstd compression option Bruno Thomsen
2020-08-03  6:30   ` Michael Olbrich [this message]
2020-07-24 15:51 ` [ptxdist] [PATCH v3 4/5] host-squashfs-tools: conditional select lzo and xz dependencies Bruno Thomsen
2020-08-03  6:30   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-07-24 15:51 ` [ptxdist] [PATCH v3 5/5] host-squashfs-tools: fix lz4 compression option Bruno Thomsen
2020-08-03  6:30   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-08-03  6:29 ` [ptxdist] [APPLIED] host-zstd: new package Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1k2Tyy-00029W-4i@dude02.hi.pengutronix.de \
    --to=mol@pengutronix.de \
    --cc=bruno.thomsen@gmail.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox