mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <mol@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] busybox: bring back and reorder the stage separator comments
Date: Mon, 03 Aug 2020 08:29:57 +0200	[thread overview]
Message-ID: <E1k2Tyv-0001zo-0y@dude02.hi.pengutronix.de> (raw)
In-Reply-To: <20200723095027.3673-2-rhi@pengutronix.de>

Thanks, applied as b65290de7455a93db53e0c0d233ee1bd2f7ec674.

Michael

[sent from post-receive hook]

On Mon, 03 Aug 2020 08:29:57 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> Even if the default compile stage is used, its variables deserve a
> recognisable header for better navigation. The BUSYBOX_INSTALL_OPT
> variable belongs to the install stage, so move the Install header.
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20200723095027.3673-2-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/busybox.make b/rules/busybox.make
> index 5c87c17ba4d4..9870414d0b32 100644
> --- a/rules/busybox.make
> +++ b/rules/busybox.make
> @@ -48,6 +48,10 @@ ifeq ($(BUSYBOX_ARCH),i386)
>  BUSYBOX_ARCH := x86
>  endif
>  
> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
> +
>  # does not build reproducibly unless we set KCONFIG_NOTIMESTAMP
>  BUSYBOX_MAKE_OPT := \
>  	KCONFIG_NOTIMESTAMP=1 \
> @@ -65,15 +69,15 @@ BUSYBOX_MAKE_ENV := \
>  	$(CROSS_ENV) \
>  	SKIP_STRIP=y
>  
> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
>  BUSYBOX_INSTALL_OPT := \
>  	$(BUSYBOX_MAKE_OPT) \
>  	CONFIG_PREFIX=$(BUSYBOX_PKGDIR)/usr \
>  	install
>  
> -# ----------------------------------------------------------------------------
> -# Install
> -# ----------------------------------------------------------------------------
> -
>  $(STATEDIR)/busybox.install:
>  	@$(call targetinfo)
>  	@$(call world/install, BUSYBOX)

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2020-08-03  6:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23  9:50 [ptxdist] [PATCH 1/2] rules: remove redundant KCONFIG_NOTIMESTAMP from package environments Roland Hieber
2020-07-23  9:50 ` [ptxdist] [PATCH 2/2] busybox: bring back and reorder the stage separator comments Roland Hieber
2020-08-03  6:29   ` Michael Olbrich [this message]
2020-08-03  6:29 ` [ptxdist] [APPLIED] rules: remove redundant KCONFIG_NOTIMESTAMP from package environments Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1k2Tyv-0001zo-0y@dude02.hi.pengutronix.de \
    --to=mol@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox