From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
In-Reply-To: <20200720162944.7332-1-bruno.thomsen@gmail.com>
MIME-Version: 1.0
Message-Id: <E1k2Tys-0001oa-0m@dude02.hi.pengutronix.de>
From: Michael Olbrich <mol@pengutronix.de>
Date: Mon, 03 Aug 2020 08:29:54 +0200
Subject: Re: [ptxdist] [APPLIED] modemmanager: config: allow arbitrary AT
 command via DBus
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>

Thanks, applied as 7e2314713f6e877bba4ed18d4af886ee7e82e56f.

Michael

[sent from post-receive hook]

On Mon, 03 Aug 2020 08:29:54 +0200, Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
> This feature is useful when needing to approve a device
> under RED directive for the EU market where it's required
> to use the same firmware that ships to customers during
> radio testing. As this work typically involves the use of
> hidden/custom commands not need for every day operation.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> Message-Id: <20200720162944.7332-1-bruno.thomsen@gmail.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/modemmanager.in b/rules/modemmanager.in
> index 50f2d9c6af9d..5b8d03016506 100644
> --- a/rules/modemmanager.in
> +++ b/rules/modemmanager.in
> @@ -2,6 +2,7 @@
>  
>  menuconfig MODEMMANAGER
>  	tristate
> +	select DBUS		if MODEMMANAGER_ALLOW_DBUS_AT_CMDS && RUNTIME
>  	select GLIB
>  	select UDEV
>  	select LIBGUDEV
> @@ -24,4 +25,8 @@ config MODEMMANAGER_SYSTEMD_UNIT
>  	depends on SYSTEMD
>  	prompt "install systemd unit file"
>  
> +config MODEMMANAGER_ALLOW_DBUS_AT_CMDS
> +	bool
> +	prompt "allow arbitrary AT commands via DBus"
> +
>  endif
> diff --git a/rules/modemmanager.make b/rules/modemmanager.make
> index b26e47c4aec7..5cae10024bbd 100644
> --- a/rules/modemmanager.make
> +++ b/rules/modemmanager.make
> @@ -50,7 +50,7 @@ MODEMMANAGER_CONF_OPT	:= \
>  	--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-suspend-resume \
>  	--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-journal \
>  	--without-polkit \
> -	--without-at-command-via-dbus \
> +	--$(call ptx/wwo, PTXCONF_MODEMMANAGER_ALLOW_DBUS_AT_CMDS)-at-command-via-dbus \
>  	--with-mbim \
>  	--with-qmi
>  

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de