[ptxdist] [PATCH v3] modemmanager: config: allow arbitrary AT command via DBus

[ptxdist] [PATCH v3] modemmanager: config: allow arbitrary AT command via DBus

[Bruno Thomsen]

This feature is useful when needing to approve a device
under RED directive for the EU market where it's required
to use the same firmware that ships to customers during
radio testing. As this work typically involves the use of
hidden/custom commands not need for every day operation.

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
Since version 2:
mol: DBUS is only a runtime dependency.

Since version 1:
rhi: use select DBUS dependency.

 rules/modemmanager.in   | 5 +++++
 rules/modemmanager.make | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/rules/modemmanager.in b/rules/modemmanager.in
index 50f2d9c6a..5b8d03016 100644
--- a/rules/modemmanager.in
+++ b/rules/modemmanager.in
@@ -2,6 +2,7 @@
 
 menuconfig MODEMMANAGER
 	tristate
+	select DBUS		if MODEMMANAGER_ALLOW_DBUS_AT_CMDS && RUNTIME
 	select GLIB
 	select UDEV
 	select LIBGUDEV
@@ -24,4 +25,8 @@ config MODEMMANAGER_SYSTEMD_UNIT
 	depends on SYSTEMD
 	prompt "install systemd unit file"
 
+config MODEMMANAGER_ALLOW_DBUS_AT_CMDS
+	bool
+	prompt "allow arbitrary AT commands via DBus"
+
 endif
diff --git a/rules/modemmanager.make b/rules/modemmanager.make
index b26e47c4a..5cae10024 100644
--- a/rules/modemmanager.make
+++ b/rules/modemmanager.make
@@ -50,7 +50,7 @@ MODEMMANAGER_CONF_OPT	:= \
 	--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-suspend-resume \
 	--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-journal \
 	--without-polkit \
-	--without-at-command-via-dbus \
+	--$(call ptx/wwo, PTXCONF_MODEMMANAGER_ALLOW_DBUS_AT_CMDS)-at-command-via-dbus \
 	--with-mbim \
 	--with-qmi
 

base-commit: e37db9dbf300a5921055a47748291dcc580feca0
-- 
2.26.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [APPLIED] modemmanager: config: allow arbitrary AT command via DBus

[Michael Olbrich]

Thanks, applied as 7e2314713f6e877bba4ed18d4af886ee7e82e56f.

Michael

[sent from post-receive hook]

On Mon, 03 Aug 2020 08:29:54 +0200, Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
> This feature is useful when needing to approve a device
> under RED directive for the EU market where it's required
> to use the same firmware that ships to customers during
> radio testing. As this work typically involves the use of
> hidden/custom commands not need for every day operation.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> Message-Id: <20200720162944.7332-1-bruno.thomsen@gmail.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/modemmanager.in b/rules/modemmanager.in
> index 50f2d9c6af9d..5b8d03016506 100644
> --- a/rules/modemmanager.in
> +++ b/rules/modemmanager.in
> @@ -2,6 +2,7 @@
>  
>  menuconfig MODEMMANAGER
>  	tristate
> +	select DBUS		if MODEMMANAGER_ALLOW_DBUS_AT_CMDS && RUNTIME
>  	select GLIB
>  	select UDEV
>  	select LIBGUDEV
> @@ -24,4 +25,8 @@ config MODEMMANAGER_SYSTEMD_UNIT
>  	depends on SYSTEMD
>  	prompt "install systemd unit file"
>  
> +config MODEMMANAGER_ALLOW_DBUS_AT_CMDS
> +	bool
> +	prompt "allow arbitrary AT commands via DBus"
> +
>  endif
> diff --git a/rules/modemmanager.make b/rules/modemmanager.make
> index b26e47c4aec7..5cae10024bbd 100644
> --- a/rules/modemmanager.make
> +++ b/rules/modemmanager.make
> @@ -50,7 +50,7 @@ MODEMMANAGER_CONF_OPT	:= \
>  	--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-suspend-resume \
>  	--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-journal \
>  	--without-polkit \
> -	--without-at-command-via-dbus \
> +	--$(call ptx/wwo, PTXCONF_MODEMMANAGER_ALLOW_DBUS_AT_CMDS)-at-command-via-dbus \
>  	--with-mbim \
>  	--with-qmi
>  

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de