From: Michael Olbrich <mol@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>
Subject: Re: [ptxdist] [APPLIED] modemmanager: config: allow arbitrary AT command via DBus
Date: Mon, 03 Aug 2020 08:29:54 +0200 [thread overview]
Message-ID: <E1k2Tys-0001oa-0m@dude02.hi.pengutronix.de> (raw)
In-Reply-To: <20200720162944.7332-1-bruno.thomsen@gmail.com>
Thanks, applied as 7e2314713f6e877bba4ed18d4af886ee7e82e56f.
Michael
[sent from post-receive hook]
On Mon, 03 Aug 2020 08:29:54 +0200, Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
> This feature is useful when needing to approve a device
> under RED directive for the EU market where it's required
> to use the same firmware that ships to customers during
> radio testing. As this work typically involves the use of
> hidden/custom commands not need for every day operation.
>
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> Message-Id: <20200720162944.7332-1-bruno.thomsen@gmail.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/modemmanager.in b/rules/modemmanager.in
> index 50f2d9c6af9d..5b8d03016506 100644
> --- a/rules/modemmanager.in
> +++ b/rules/modemmanager.in
> @@ -2,6 +2,7 @@
>
> menuconfig MODEMMANAGER
> tristate
> + select DBUS if MODEMMANAGER_ALLOW_DBUS_AT_CMDS && RUNTIME
> select GLIB
> select UDEV
> select LIBGUDEV
> @@ -24,4 +25,8 @@ config MODEMMANAGER_SYSTEMD_UNIT
> depends on SYSTEMD
> prompt "install systemd unit file"
>
> +config MODEMMANAGER_ALLOW_DBUS_AT_CMDS
> + bool
> + prompt "allow arbitrary AT commands via DBus"
> +
> endif
> diff --git a/rules/modemmanager.make b/rules/modemmanager.make
> index b26e47c4aec7..5cae10024bbd 100644
> --- a/rules/modemmanager.make
> +++ b/rules/modemmanager.make
> @@ -50,7 +50,7 @@ MODEMMANAGER_CONF_OPT := \
> --$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-suspend-resume \
> --$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-journal \
> --without-polkit \
> - --without-at-command-via-dbus \
> + --$(call ptx/wwo, PTXCONF_MODEMMANAGER_ALLOW_DBUS_AT_CMDS)-at-command-via-dbus \
> --with-mbim \
> --with-qmi
>
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
prev parent reply other threads:[~2020-08-03 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 16:29 [ptxdist] [PATCH v3] " Bruno Thomsen
2020-08-03 6:29 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1k2Tys-0001oa-0m@dude02.hi.pengutronix.de \
--to=mol@pengutronix.de \
--cc=bruno.thomsen@gmail.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox