From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
In-Reply-To: <20200515142641.812-8-bst@pengutronix.de>
MIME-Version: 1.0
Message-Id: <E1jb1HZ-0001BX-5W@dude02.lab.pengutronix.de>
From: Michael Olbrich <mol@pengutronix.de>
Date: Tue, 19 May 2020 14:23:41 +0200
Subject: Re: [ptxdist] [APPLIED]
 ptxd_lib_imx_hab/template-barebox-imx-habv4: make number of SRKs
 configurable
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bastian Krause <bst@pengutronix.de>

Thanks, applied as 3e150564474af6cd16ef804d7226ef5237c74c11.

Michael

[sent from post-receive hook]

On Tue, 19 May 2020 14:23:41 +0200, Bastian Krause <bst@pengutronix.de> wrote:
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> Message-Id: <20200515142641.812-8-bst@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/templates/template-barebox-imx-habv4-make b/rules/templates/template-barebox-imx-habv4-make
> index d8086f0cf057..ec402afa1edf 100644
> --- a/rules/templates/template-barebox-imx-habv4-make
> +++ b/rules/templates/template-barebox-imx-habv4-make
> @@ -74,7 +74,7 @@ $(STATEDIR)/barebox-@package@.compile:
>  	@$(call targetinfo)
>  
>  	@$(call world/env, BAREBOX_@PACKAGE@) \
> -		ptxd_make_imx_habv4_gen_table "imx-habv4-srk%d"
> +		ptxd_make_imx_habv4_gen_table "imx-habv4-srk%d" 4
>  
>  	@$(call world/compile, BAREBOX_@PACKAGE@)
>  
> diff --git a/scripts/lib/ptxd_lib_imx_hab.sh b/scripts/lib/ptxd_lib_imx_hab.sh
> index 781c1b3f610e..d1e2aba99fab 100644
> --- a/scripts/lib/ptxd_lib_imx_hab.sh
> +++ b/scripts/lib/ptxd_lib_imx_hab.sh
> @@ -9,10 +9,12 @@
>  #
>  # ptxd_make_imx_habv4_gen_table - generate the srk fuse file and srk table for i.MX HABv4
>  #
> -# usage: ptxd_make_imx_habv4_gen_table <template>
> +# usage: ptxd_make_imx_habv4_gen_table <template> [<srk_count>]
>  #
>  # template: the role template to access the keys. Must contain a "%d" which is
>  #           used as index
> +# srk_count: the number of keys (keys with index 1..srk_count will be used),
> +#            defaults to 4
>  #
>  # The output files are generated in the package build dir:
>  #
> @@ -24,13 +26,22 @@
>  #
>  ptxd_make_imx_habv4_gen_table_impl() {
>      local template="${1}"
> +    local srk_count="${2}"
>      local table_bin="${pkg_build_dir}/imx-srk-table.bin"
>      local srk_fuse_bin="${pkg_build_dir}/imx-srk-fuse.bin"
>      local -a certs
>  
> +    if [ -z "${srk_count}" ]; then
> +	srk_count=4
> +    fi
> +
> +    if [ "${srk_count}" -gt 4 ]; then
> +	ptxd_bailout "HABv4 allows only 4 certificates"
> +    fi
> +
>      echo -e "generating $(basename ${table_bin}) and $(basename ${srk_fuse_bin})\n"
>  
> -    for i in 1 2 3 4; do
> +    for i in $(seq ${srk_count}); do
>  	certs[${#certs[*]}]="$(cs_get_ca "$(printf "${template}" ${i})")"
>      done
>  

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de