From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
In-Reply-To: <20200515142641.812-4-bst@pengutronix.de>
MIME-Version: 1.0
Message-Id: <E1jb1HW-00019c-QD@dude02.lab.pengutronix.de>
From: Michael Olbrich <mol@pengutronix.de>
Date: Tue, 19 May 2020 14:23:38 +0200
Subject: Re: [ptxdist] [APPLIED] ptxd_lib_imx_hab: fix srk fuse file and
 table generation
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bastian Krause <bst@pengutronix.de>

Thanks, applied as 62b473be8da55fdc020c630004efab881c78b9d4.

Michael

[sent from post-receive hook]

On Tue, 19 May 2020 14:23:38 +0200, Bastian Krause <bst@pengutronix.de> wrote:
> srktool's help text states "certificate filenames must be separated by
> a ',' with no spaces". Line continuating using "\" with the next line
> being indented leads to a space being inserted between the SRK2
> certificate and the SRK3 certificate.
> srktool does not fail, but ignores everything after the space silently.
> Thus only the first two certicates end up in the fuse file and table.
> 
> Fix this by specifying all certs on a single line.
> 
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> Message-Id: <20200515142641.812-4-bst@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/scripts/lib/ptxd_lib_imx_hab.sh b/scripts/lib/ptxd_lib_imx_hab.sh
> index 8be376ff12c9..034bf82b232a 100644
> --- a/scripts/lib/ptxd_lib_imx_hab.sh
> +++ b/scripts/lib/ptxd_lib_imx_hab.sh
> @@ -43,8 +43,7 @@ ptxd_make_imx_habv4_gen_table_impl() {
>  	--table "${table_bin}" \
>  	--efuses "${srk_fuse_bin}" \
>  	--digest sha256 \
> -	--certs ${tmpdir}/srk1.pem,${tmpdir}/srk2.pem,\
> -	    ${tmpdir}/srk3.pem,${tmpdir}/srk4.pem
> +	--certs ${tmpdir}/srk1.pem,${tmpdir}/srk2.pem,${tmpdir}/srk3.pem,${tmpdir}/srk4.pem
>  }
>  export -f ptxd_make_imx_habv4_gen_table_impl
>  

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de