mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Lucas Sinn <Lucas.Sinn@wolfvision.net>
To: Michael Olbrich <m.olbrich@pengutronix.de>,
	"ptxdist@pengutronix.de" <ptxdist@pengutronix.de>
Subject: Re: [ptxdist] [PATCH v2] glibmm: add new package
Date: Thu, 8 Aug 2024 16:00:07 +0000	[thread overview]
Message-ID: <DU0PR08MB81859BD927085F7DFC361580E1B92@DU0PR08MB8185.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <ZrTVXZlD0ydqrYh5@pengutronix.de>

> On Thu, Aug 08, 2024 at 02:46:15PM +0200, Lucas Sinn wrote:
> > Signed-off-by: Lucas Sinn <lucas.sinn@wolfvision.net>
> > ---
> > Amending the proper licence version to GLIBMM_LICENCE variable
> >
> >  rules/glibmm.in   | 10 +++++++
> >  rules/glibmm.make | 71 
> > +++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 81 insertions(+)
> >  create mode 100644 rules/glibmm.in
> >  create mode 100644 rules/glibmm.make
> >
> > diff --git a/rules/glibmm.in b/rules/glibmm.in new file mode 100644 
> > index 000000000..5b6e4646e
> > --- /dev/null
> > +++ b/rules/glibmm.in
> > @@ -0,0 +1,10 @@
> > +## SECTION=multimedia_gtk
> > +
> > +config GLIBMM
> > +     tristate
> > +     select HOST_MESON
> > +     select GLIB
> > +     select LIBSIGCPP
> 
> libsigcpp is currently in staging, because the version in ptxdist is old and fails to build with newer compilers. This package must be updated as well.
> 

libsigcpp is being updated by another patch i submitted already. I just did not combine these both patches which may have made sense when iam thinking
about it.

> > +     prompt "glibmm"
> > +     help
> > +       C++ wrapper for glib
> > diff --git a/rules/glibmm.make b/rules/glibmm.make new file mode 
> > 100644 index 000000000..90444144f
> > --- /dev/null
> > +++ b/rules/glibmm.make
> > @@ -0,0 +1,71 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2024 by Lucas Sinn <lucas.sinn@wolfvision.net> # # 
> > +For further information about the PTXdist project and license 
> > +conditions # see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_GLIBMM) += glibmm
> > +
> > +#
> > +# Paths and names
> > +#
> > +GLIBMM_VERSION       := 2.78.1
> > +GLIBMM_MD5   := 52b93bf93de45e5a6b3c321bc832cd9c
> > +GLIBMM               := glibmm-$(GLIBMM_VERSION)
> > +GLIBMM_SUFFIX        := tar.xz
> > +GLIBMM_URL   := $(call ptx/mirror, GNOME, glibmm/$(basename $(GLIBMM_VERSION))/$(GLIBMM).$(GLIBMM_SUFFIX))
> > +GLIBMM_SOURCE        := $(SRCDIR)/$(GLIBMM).$(GLIBMM_SUFFIX)
> > +GLIBMM_DIR   := $(BUILDDIR)/$(GLIBMM)
> > +GLIBMM_LICENSE       := LGPL-2.1-only AND GPL-2.0-only
> > +GLIBMM_LICENSE_FILES := \
> > +     file://COPYING;md5=42dfffebc56fec7527aac53b7a89d1d8 \
> > +     file://COPYING.tools;md5=751419260aa954499f7abaabaa882bbe
> > +
> > +# 
> > +---------------------------------------------------------------------
> > +-------
> > +# Prepare
> > +# 
> > +---------------------------------------------------------------------
> > +-------
> > +
> > +GLIBMM_MESON_CROSS_FILE := $(call ptx/get-alternative, config/meson, 
> > +glib-cross-file.meson)
> 
> Are you sure that this is needed? Non of the variables specified here seem to be used.
> 
> Michael

You are right. The variables aren't needed. Adding it to the patch.

- Lucas

> > +#
> > +# meson
> > +#
> > +GLIBMM_CONF_TOOL  := meson
> > +GLIBMM_CONF_OPT   := \
> > +        $(CROSS_MESON_USR) \
> > +        -Dbuild-deprecated-api=false \
> > +        -Dbuild-documentation=false \
> > +        -Dbuild-examples=false \
> > +        -Ddebug-refcounting=false \
> > +        -Ddist-warnings=fatal \
> > +        -Dmaintainer-mode=false \
> > +        -Dmsvc14x-parallel-installable=false \
> > +        -Dwarnings=max \
> > +        \
> > +        --cross-file $(GLIB_MESON_CROSS_FILE)
> > +
> > +# 
> > +---------------------------------------------------------------------
> > +-------
> > +# Target-Install
> > +# 
> > +---------------------------------------------------------------------
> > +-------
> > +
> > +$(STATEDIR)/glibmm.targetinstall:
> > +     @$(call targetinfo)
> > +
> > +     @$(call install_init, glibmm)
> > +     @$(call install_fixup, glibmm,PRIORITY,optional)
> > +     @$(call install_fixup, glibmm,SECTION,base)
> > +     @$(call install_fixup, glibmm,AUTHOR,"Lucas Sinn <lucas.sinn@wolfvision.net>")
> > +     @$(call install_fixup, glibmm,DESCRIPTION,missing)
> > +
> > +     @$(call install_lib, glibmm, 0, 0, 0644, libglibmm-2.68)
> > +     @$(call install_lib, glibmm, 0, 0, 0644, libgiomm-2.68)
> > +
> > +     @$(call install_finish, glibmm)
> > +
> > +     @$(call touch)
> > +
> > +# vim: syntax=make
> > --
> > 2.37.2
> >
> >
> > Lucas Sinn
> > R&D Engineer
> >
> > Wolfvision GmbH
> > Oberes Ried 14 | 6833 Klaus | Austria
> > Tel: +43 5523 52250 <tel:+43552352250> | Mail: 
> > lucas.sinn@wolfvision.net <mailto:lucas.sinn@wolfvision.net>
> >
> > Website: wolfvision.com <www.wolfvision.com> Firmenbuch / Commercial 
> > Register: FN283521v Feldkirch/Austria
> >
> >
> >
> 
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Lucas Sinn 
R&D Engineer

Wolfvision GmbH 
Oberes Ried 14 | 6833 Klaus | Austria 
Tel: +43 5523 52250 <tel:+43552352250> | Mail: lucas.sinn@wolfvision.net <mailto:lucas.sinn@wolfvision.net>

Website: wolfvision.com <www.wolfvision.com> 
Firmenbuch / Commercial Register: FN283521v Feldkirch/Austria




      reply	other threads:[~2024-08-08 17:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <016db821-bc16-4106-ab26-ac766a339fab.e0c24246-04d4-485f-8d5f-1cc8fbefd095.3dc9a7b9-65b1-4651-bebc-0d55527def10@emailsignatures365.codetwo.com>
2024-08-08 12:46 ` Lucas Sinn
2024-08-08 14:25   ` Michael Olbrich
2024-08-08 16:00     ` Lucas Sinn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DU0PR08MB81859BD927085F7DFC361580E1B92@DU0PR08MB8185.eurprd08.prod.outlook.com \
    --to=lucas.sinn@wolfvision.net \
    --cc=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox