Re: [ptxdist] [PATCH] Add persistant iptable-rules via systemd

["Schenk, Gavin" <G.Schenk@eckelmann.de>]

Hi,

> > +for table in $(</proc/net/ip6_tables_names)
> 
> This does not work with a busybox /bin/sh. I think that's bashism.
> 
> This should work:
> 
> for table in $(cat /proc/net/ip6_tables_names); do ...
> 
> Note: It doesn't fail! The list is always empty!

Grrrr Uwe told me about the tool checkbashism last week, but I forgot to use it here :(.
I tested the implementation with cat and it works! 

> > +	@$(call install_link, iptables, ../ip6tables.service,
> > +/lib/systemd/system/multi-user.target.wants/ip6tables.service)
> 
> 	@$(call install_link, iptables, ../ip6tables.service,  \
> 		/lib/systemd/system/multi-
> user.target.wants/ip6tables.service)
> 
> Break like this.

Can you please tell me about the limits of columns in makefiles, or where I can read about it?
In some Makefiles more than 80 columns are used. Is there a kind of hard- and soft-limit :)?

I´ ll send a new patch after testing the changes

Regards
Gavin
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de