From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ob0-f172.google.com ([209.85.214.172]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1ScipF-00024a-9n for ptxdist@pengutronix.de; Thu, 07 Jun 2012 21:57:17 +0200 Received: by obbeh20 with SMTP id eh20so1628359obb.31 for ; Thu, 07 Jun 2012 12:56:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <201008061357.35512.linz@li-pro.net> References: <7bcf52a941a5c6adc56ff28b0a7b34bfde104cdf.1281035180.git.linz@li-pro.net> <4C5BB7B1.7080502@pengutronix.de> <201008061357.35512.linz@li-pro.net> Date: Thu, 7 Jun 2012 16:56:50 -0300 Message-ID: From: Flavio de Castro Alves Filho Subject: Re: [ptxdist] [PATCH 1/1] add new packet x-load Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1122043763==" Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de --===============1122043763== Content-Type: multipart/alternative; boundary=e89a8f6471b1d6560c04c1e7486a --e89a8f6471b1d6560c04c1e7486a Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hello, I'm affraid that the file x-load-f243938.tar.bz2 located at the repository is not fine. I was unable to build MLO file with that file. Comparing with the git repository (https://git.gitorious.org/x-load-omap3/mainline.git), I could find the ift target. Best regards, Flavio Flavio de Castro Alves Filho Phi Innovations www.phiinnovations.com Phone: +55 19 3709 1358 Mobile: +55 19 9823 9332 Skype: flavio.de.castro.alves.filho 2010/8/6 Stephan Linz > Am Freitag, 6. August 2010, um 09:20:17 schrieb Marc Kleine-Budde: > > ---snip-- > > > > tnx, pushed to master. > > > > but, crap, it doesn't work :(...see inline comments: > > > --snip-- > > > +X_LOAD_MAKE_OPT :=3D CROSS_COMPILE=3D$(BOOTLOADER_CROSS_COMPILE) > > > HOSTCC=3D$(HOSTCC) +X_LOAD_MAKE_PAR :=3D NO > > > + > > > +$(STATEDIR)/x-load.prepare: > > > + @$(call targetinfo) > > > + @$(call compile, X_LOAD, $(PTXCONF_X_LOAD_CONFIG)) > > > > ^^^^^^^^^^^^^^^^^^^^^^^^ > > > > I think the second parameter overwrites _MAKE_OPT. I'm not sure why it > > does this, looks like a bug. It should be fixed, but that requires some > > time and testing... > > > > However I can work around this limitation by changing _MAKE_OPT to > > _MAKE_ENV. > > This surprises me because it has properly compiled for me > > > > > I'll push this fix. > > > tnx a lot. I'll try out your fix. Give me a hint (here). > > > -- > Viele Gr=FC=DFe, > Stephan Linz > > _________________________________________________________________________= _____ > OpenDCC: http://www.li-pro.net/opendcc.phtml > PC/M: http://www.li-pro.net/pcm.phtml > CDK4AVR: http://cdk4avr.sourceforge.net/ > CDK4NIOS: http://cdk4nios.sourceforge.net/ > CDK4MSP: http://cdk4msp.sourceforge.net/ > CPM4L: http://download.opensuse.org/repositories/home:/rexut:/CPM4L > > -- > ptxdist mailing list > ptxdist@pengutronix.de > --e89a8f6471b1d6560c04c1e7486a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hello,

I'm affraid that the file x-load-f243938.tar.= bz2 located at the repository is not fine.

I was u= nable to build MLO file with that file. Comparing with the git repository (= https://git= .gitorious.org/x-load-omap3/mainline.git), I could find the ift target.=

Best regards,

Flavio

Flavio de Castro Alves Filho
Phi Innovations
www.phiinnovations.c= om
Phone: +55 19 3709 1358
Mobile: +55 19 9823 9332
Skype: flavio.de.cas= tro.alves.filho


2010/8/6 Stephan Linz = <linz@li-pro.net>
Am Freitag, 6. August 2010, um 09:20:17 schrieb Marc Kleine-Budde:
> ---snip--
>
> tnx, pushed to master.
>
> but, crap, it doesn't work :(...see inline comments:
> > --snip--
> > +X_LOAD_MAKE_OPT =A0 =A0:=3D CROSS_COMPILE=3D$(= BOOTLOADER_CROSS_COMPILE)
> > HOSTCC=3D$(HOSTCC) +X_LOAD_MAKE_PAR =A0 :=3D NO
> > +
> > +$(STATEDIR)/x-load.prepare:
> > + =A0 @$(call targetinfo)
> > + =A0 @$(call compile, X_LOAD, $(PTXCONF_X_LOAD_CONFIG))
>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0^^^= ^^^^^^^^^^^^^^^^^^^^^
>
> I think the second parameter overwrites _MAKE_OPT. I'm not sure wh= y it
> does this, looks like a bug. It should be fixed, but that requires som= e
> time and testing...
>
> However I can work around this limitation by changing _MAKE_OPT to
> _MAKE_ENV.

This surprises me because it has properly compiled for me

>
> I'll push this fix.
>
tnx a lot. =A0I'll try out your fix. Give me a hint (here).


--
Viele Gr=FC=DFe,
Stephan Linz
___________________________________________________________________________= ___
OpenDCC: = http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
CDK4AVR: = http://cdk4avr.sourceforge.net/
CDK4NIOS: http://cdk4nios.sourceforge.net/
CDK4MSP: = http://cdk4msp.sourceforge.net/
CPM4L: http://download.opensuse.org/repositories/home:/rexu= t:/CPM4L

--
ptxdist mailing list
ptxdist@pengutronix.de

--e89a8f6471b1d6560c04c1e7486a-- --===============1122043763== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- ptxdist mailing list ptxdist@pengutronix.de --===============1122043763==--